989331 - Implement fireplace-specific collection endpoint/serializer

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Mathieu Pillard [:mat]]

Fireplace uses /rocketfuel/collections/ and /fireplace/search/featured/ endpoints when dealing with collections. Both use the default CollectionSerializer, which returns a bunch of data Fireplace doesn't need, we should have a fireplace-specific one.

Also, this serializer uses SimpleAppSerializer and SimpleESAppSerializer, so for apps inside a collection we also return some info that fireplace doesn't need. The new, fireplace-specific Collection serializer should use FireplaceAppSerializer and FireplaceESAppSerializer to further reduce the amount of information sent to fireplace.

Comment 1

[Mathieu Pillard [:mat]]

Because we want to avoid duplicating endpoints all the time, I'm making this bug depend on bug 989397. I moved the second part of comment 0, which we can easily implement right now (in fact I already have a PR for it), to a separate bug, bug 989405.

Comment 2

[Mathieu Pillard [:mat]]

bug 989405 will give us perf improvements on the homepage, the remaining stuff for this one won't, since it's only /rocketfuel/collections/, which is only used when the user clicks on a collection. Downgrading priority as a result.

Comment 3

[Mathieu Pillard [:mat]]

This is actually going to be more important to tarako, if we keep the approach described in https://github.com/cvan/metropolis/wiki/Technical-Architecture#database - Currently, metropolis uses /rocketfuel/collections/curated/, which 1) doesn't use ES for apps and 2) returns extra data about apps that we don't care about

Comment 4

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/1919

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/f780902e525dd63fdac58cf40277f26337806db0