Closed Bug 989336 Opened 6 years ago Closed 6 years ago

Uninteresting call warning from mock object in APZC gtest

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
When running "mach gtest" I see this in the output:

[ RUN      ] AsyncPanZoomControllerTester.LongPressPreventDefault

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: HandleLongTapUp(@0x7fff5fbfe888 8-byte object <00-00 20-41 00-00 48-42>, 0, @0x7fff5fbfe868 24-byte object <00-00 00-00 00-00 00-00 FF-FF FF-FF 01-00 00-00 00-00 00-00 00-00 00-00>)
Stack trace:
[       OK ] AsyncPanZoomControllerTester.LongPressPreventDefault (0 ms)

This doesn't fail the test but it's not pretty, so I'd like to clean it up. The attached patch does that.
Attachment #8398513 - Flags: review?(dmitry.rojkov)
Comment on attachment 8398513 [details] [diff] [review]
Patch

Review of attachment 8398513 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, I agree this expectation is quite reasonable.

But I can't see a button to stamp my approval. Probably I don't have enough permissions for that.
(In reply to dmitry.rojkov from comment #1)
> But I can't see a button to stamp my approval. Probably I don't have enough
> permissions for that.

Oh, weird. I thought you had review permissions on Bugzilla already. I asked :dkl on #bmo to give you permissions and he said you should be able to now.
Attachment #8398513 - Flags: review?(dmitry.rojkov) → review+
Thanks! Updated patch to include bug number and reviewer, carrying r+
Attachment #8398513 - Attachment is obsolete: true
Attachment #8398641 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/031f343c8754
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.