989336 - Uninteresting call warning from mock object in APZC gtest

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

When running "mach gtest" I see this in the output:

[ RUN      ] AsyncPanZoomControllerTester.LongPressPreventDefault

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: HandleLongTapUp(@0x7fff5fbfe888 8-byte object <00-00 20-41 00-00 48-42>, 0, @0x7fff5fbfe868 24-byte object <00-00 00-00 00-00 00-00 FF-FF FF-FF 01-00 00-00 00-00 00-00 00-00 00-00>)
Stack trace:
[       OK ] AsyncPanZoomControllerTester.LongPressPreventDefault (0 ms)

This doesn't fail the test but it's not pretty, so I'd like to clean it up. The attached patch does that.

Comment 1

[dmitry.rojkov]

Comment on attachment 8398513 [details] [diff] [review]
Patch

Review of attachment 8398513 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, I agree this expectation is quite reasonable.

But I can't see a button to stamp my approval. Probably I don't have enough permissions for that.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to dmitry.rojkov from comment #1)
> But I can't see a button to stamp my approval. Probably I don't have enough
> permissions for that.

Oh, weird. I thought you had review permissions on Bugzilla already. I asked :dkl on #bmo to give you permissions and he said you should be able to now.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch for checkin

Thanks! Updated patch to include bug number and reviewer, carrying r+

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/031f343c8754

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/031f343c8754