Closed Bug 989364 Opened 8 years ago Closed 8 years ago

Netmonitor should use CurlUtils to retrieve the request headers from upload stream

Categories

(DevTools :: Netmonitor, defect)

Product:
DevTools
Component:
Netmonitor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 31

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

v1
4.62 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review 
DRY things up a little.
Attached patch v1 — — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8398579 - Flags: review?(rcampbell)
Comment on attachment 8398579 [details] [diff] [review]
v1

Review of attachment 8398579 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/test/html_post-raw-with-headers-test-page.html
@@ +28,5 @@
>          var rawData = [
> +          "content-type: application/x-www-form-urlencoded\r",
> +          "custom-header: hello world!\r",
> +          "\r",
> +          "\r",

wat
Attachment #8398579 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> Comment on attachment 8398579 [details] [diff] [review]

That's actually the correct way of having request headers in the upload stream.
https://hg.mozilla.org/mozilla-central/rev/df5d6afaccdc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.