Closed
Bug 989364
Opened 11 years ago
Closed 11 years ago
Netmonitor should use CurlUtils to retrieve the request headers from upload stream
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
|
4.62 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
DRY things up a little.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8398579 [details] [diff] [review]
v1
Review of attachment 8398579 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/netmonitor/test/html_post-raw-with-headers-test-page.html
@@ +28,5 @@
> var rawData = [
> + "content-type: application/x-www-form-urlencoded\r",
> + "custom-header: hello world!\r",
> + "\r",
> + "\r",
wat
Attachment #8398579 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> Comment on attachment 8398579 [details] [diff] [review]
That's actually the correct way of having request headers in the upload stream.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•