989370 - Have Stale Element exception explain why it is a stale element reference

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

"StaleElementException: StaleElementException: Stale element reference"


needs to be more user friendly

Comment 1

[David Burns :automatedtester]

Attachment: Update Marionette Stale Element Reference exception to give a meaningful explanation

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8398802 [details] [diff] [review]
Update Marionette Stale Element Reference exception to give a meaningful explanation

Review of attachment 8398802 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-elements.js
@@ +119,5 @@
>      if (!el ||
>          !(XPCNativeWrapper(el).ownerDocument == wrappedWin.document) ||
>          (XPCNativeWrapper(el).compareDocumentPosition(wrappedWin.document.documentElement) &
>           DOCUMENT_POSITION_DISCONNECTED)) {
> +      throw new ElementException("The element reference appears to be stale. Either the element " +

s/appears to be/is ?

Comment 3

[David Burns :automatedtester]

Attachment: Update Marionette Stale Element Reference exception to give a meaningful explanation

Comment 4

[David Burns :automatedtester]

Comment on attachment 8399598 [details] [diff] [review]
Update Marionette Stale Element Reference exception to give a meaningful explanation

Review of attachment 8399598 [details] [diff] [review]:
-----------------------------------------------------------------

carrying on :jgriffin r+ after nit

Comment 5

[David Burns :automatedtester]

landed on https://hg.mozilla.org/integration/mozilla-inbound/rev/f035bcc3dc0e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f035bcc3dc0e