Closed Bug 989374 Opened 10 years ago Closed 10 years ago

Consolidate logic from browser_dbg_addon-* tests

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

We now have three of these tests testing SDK, restartless and unpacked-restartless add-ons in largely the same way. A lot of the code is duplicated and so should be moved into head_dbg.js.
Attached patch patchSplinter Review
Consolidates all the stuff around creating and destroying an add-on debugger instance into a single JS object instance that exposes properties useful to the tests.
Assignee: nobody → dtownsend+bugmail
Attachment #8401619 - Flags: review?(nfitzgerald)
Comment on attachment 8401619 [details] [diff] [review]
patch

Review of attachment 8401619 [details] [diff] [review]:
-----------------------------------------------------------------

Look at all them lines deleted :)
Attachment #8401619 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/413607a99942
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: