Closed Bug 989389 Opened 6 years ago Closed 5 years ago

[B2G][Email] Confirmation messages when setting or un-setting mutliple email flags are grammatically incorrect


(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Gonk (Firefox OS)
Not set


(b2g-v1.3 affected, b2g-v1.4 affected)

Tracking Status
b2g-v1.3 --- affected
b2g-v1.4 --- affected


(Reporter: jmitchell, Assigned: robert.sajdok)


(Whiteboard: burirun1.4-2)


(4 files)

Attached file logcat.txt
When setting multiple (2 as an example) email flags you are presented with a message "2 messages flag set"(screenshot 1) or "2 messages flag removed"(screenshot2).
The grammatically correct versions of these messages would have the plural s on the flags resulting in "2 message flags set" and "2 message flags removed"

Repro Steps: Pre-condition: Email account set up with multiple messages in inbox
1) Update a buri to BuildID: 20140326000201
2) Access email app
3) Open the account's Inbox and enter Edit Message View
4) Select more than 1 email
5) Select the flag icon
6) Observe the confirmation message

"2 messages flag set"

"2 message flags set"

1.4 Environmental Variables:
Device: buri 1.4 MOZ
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg


Repro frequency: 100%
See attached: logcat and 2 screenshots
This does repro on buri 1.3

1.3 Environmental Variables:
Device: buri 1.3 MOZ
BuildID: 20140326004002
Gaia: 812838ad0fabf51fa14435af562ddac6d26fa936
Gecko: ba97efb0da4b
Version: 28.0
Firmware Version: v1.2-device.cfg

Flag confirmation messages are grammatically incorrect
Attached image Screenshot1.png
Attached image Screenshot2.png
Assignee: nobody → robert.sajdok
Attached file Proposed fix.
Attachment #8400629 - Flags: review?(jrburke)
Comment on attachment 8400629 [details] [review]
Proposed fix.

Asking :stas for some l10n guidance, as he seemed to touch some of these strings before. I could see a case for using "Flag set on N messages" as an alternate, but also not sure yet if that will fit. This pull request change to use "N message flags set" also seems to work too, and will likely just take this change unless :stas indicates a preference otherwise.
Flags: needinfo?(stas)
Comment on attachment 8400629 [details] [review]
Proposed fix.

Going to go ahead and merge this as it is better than what we have now, and it is easy to revisit later if need be.
Attachment #8400629 - Flags: review?(jrburke) → review+
Flags: needinfo?(stas)
Merged to gaia master:

from pull request:
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.