Closed Bug 989425 Opened 6 years ago Closed 6 years ago

PeerConnectionImpl.cpp:137:18: warning: unused variable 'DTLS_FINGERPRINT_LENGTH' [-Wunused-const-variable]

Categories

(Core :: WebRTC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Build warning (with Clang 3.4 on Linux):
{
webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:137:18: warning: unused variable 'DTLS_FINGERPRINT_LENGTH' [-Wunused-const-variable]
}

Looks like last usage of this constant was removed in bug 946348.
Proof that it's really not used anywhere (not even in an #ifdef chunk that's turned off on my machine or anything): http://mxr.mozilla.org/mozilla-central/search?string=DTLS_FINGERPRINT_LENGTH
Attached patch fix: remove the variable (obsolete) — Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8398663 - Flags: review?(adam)
Comment on attachment 8398663 [details] [diff] [review]
fix: remove the variable

I'll review this, since it's probably my fault that it's here (and the warning has been annoying me too).
Attachment #8398663 - Flags: review?(adam) → review+
Thanks! Updated reviewer to "r=mt" in commit message, so that I can use checkin-needed for this. (Tree's closed right now, or else I'd just push.)
Attachment #8398797 - Flags: review+
Keywords: checkin-needed
Attachment #8398663 - Attachment is obsolete: true
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/bc9f6358b1c8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.