989425 - PeerConnectionImpl.cpp:137:18: warning: unused variable 'DTLS_FINGERPRINT_LENGTH' [-Wunused-const-variable]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning (with Clang 3.4 on Linux):
{
webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:137:18: warning: unused variable 'DTLS_FINGERPRINT_LENGTH' [-Wunused-const-variable]
}

Looks like last usage of this constant was removed in bug 946348.

Comment 1

[Daniel Holbert [:dholbert]]

Proof that it's really not used anywhere (not even in an #ifdef chunk that's turned off on my machine or anything): http://mxr.mozilla.org/mozilla-central/search?string=DTLS_FINGERPRINT_LENGTH

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: remove the variable

Comment 3

[Martin Thomson [:mt:]]

Comment on attachment 8398663 [details] [diff] [review]
fix: remove the variable

I'll review this, since it's probably my fault that it's here (and the warning has been annoying me too).

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix v2, for landing [updated reviewer in commit message to r=mt]

Thanks! Updated reviewer to "r=mt" in commit message, so that I can use checkin-needed for this. (Tree's closed right now, or else I'd just push.)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc9f6358b1c8

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bc9f6358b1c8