989429 - [Camera][Madai][Buri] When using seeking during video playback sometimes the share menu appears

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Marcia Knous [:marcia]]

Buri, while running with the latest master.

Gaia   287195d1fed2e6c883745d7091a4c05e56c4dbb7
SourceStamp bb4dd9872236
BuildID 20140327092814
Version 31.0a1

STR:
1. Record a video using the camera app
2. Begin playing the video by selecting the preview next to the shutter button.
3. Slide your finger back and forth to use the seek feature in the video.

Expected: Smooth seeking of the video
Actual: Pressing a little further down in the area beneath the slider reviews the other menu (trash, gallery, share).

We probably need to tighten up the area where you navigate the swipe. On the Nexus 4 I cannot replicate this issue.

Video coming.

Comment 1

[Hema Koka [:hema]]

Also happening on nexus4

Comment 3

[Hema Koka [:hema]]

Marcia, How often does this happen? Is this an extreme case of sliding back and forth vigorously or is it easily reproducible? This will help figure out impact to prioritize the fix. (Also have we regressed this from previous release)

Thanks
Hema

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8403572 [details] [review]
pull-request (master)

A few nits on github. I'm giving r- because I'm worried about a race condition where the user stops a video and then restarts it in < 300ms.  See github for that, too.

Overall, though, this looks like a good patch that tightens things up nicely.

There will probably be merge conflicts with 989361, so whichever of us lands second will have to resolve conficts, I think.

Comment 6

[David Flanagan [:djf]]

I actually meant a merge conflict with 987569.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8403572 [details] [review]
pull-request (master)

David: I have addressed your comments. Please re-review when you get a chance. Thanks!

Comment 8

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8403572 [details] [review]
pull-request (master)

I wasn't able to get the share menu to come up so seems good! Thanks Justin.

Comment 9

[Amy Lee [:amylee] UX]

Comment on attachment 8403572 [details] [review]
pull-request (master)

Wasn't able to reproduce the issue so +

Comment 10

[David Flanagan [:djf]]

Comment on attachment 8403572 [details] [review]
pull-request (master)

Looks good.  I haven't actually tried it, but the code looks good and Justin, Amy and Tif have all actually run it.

Comment 11

[Marcia Knous [:marcia]]

(In reply to Hema Koka [:hema] from comment #3)
> Marcia, How often does this happen? Is this an extreme case of sliding back
> and forth vigorously or is it easily reproducible? This will help figure out
> impact to prioritize the fix. (Also have we regressed this from previous
> release)
> 
> Thanks
> Hema

On Buri this happens quite easily, even using the latest nightly build. Either with a light touch or a heavy touch it occurs. For those that are unable to reproduce, are you sure you are running with the 1.2 base image?

Comment 12

[Justin D'Arcangelo [:justindarc]]

Marcia: This does happen very easily. I will be landing the patch here shortly, if Travis CI ever picks up the pace today :-/

Comment 13

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/81de58c72b2e1fca2b128a91d038538e3460b747

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v1.4 uplift.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/197eef671b22079ae3ab9a7b4d63db34e03c0f9e

Comment 16

[Marcia Knous [:marcia]]

Looks good on Buri using:

Gaia   f3abbd2d0a60f1a1618db93f8b1957cae6de379c
SourceStamp 215080b813a7
BuildID 20140414040203
Version 31.0a1

Will check 1.4 when it is in that build.