Closed Bug 989470 Opened 10 years ago Closed 10 years ago

New Marketplace package

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: clouserw, Assigned: cvan)

References

Details

(Whiteboard: [qa-])

Attachments

(3 files)

Fix MCC/MNC dual SIM detection in Marketplace app
46 bytes, text/x-github-pull-request
julienw
: review+
bajaj
: approval-gaia-v1.3+
Details | Review
V1.3 pull request
46 bytes, text/x-github-pull-request
julienw
: feedback+
Details | Review
v1.4 pull request
46 bytes, text/x-github-pull-request
julienw
: feedback+
Details | Review 
Bug 988677 fixed a bug in the Marketplace package which incorrectly detected MCC/MNC.  We should get that into 1.3T.

I think cvan makes these so assigning to him for now.

We should probably wait for bug 988677 to be verified before we land this for real
We need that on all releases that target DSDS, which is >= 1.3

So let's land on master, and ask for 1.3 blocking (this needs to be on 1.4 too!)
blocking-b2g: 1.3T? → 1.3?
blocking-b2g: 1.3? → 1.3+
Summary: New marketplace package → New Marketplace package
Julien, hi there - you had reviewed one of my Marketplace patches a while back. This is a simple change to our package, and if Fabrice can't take take a look at it, it'd be awesome if you could take a look. Thank you!
Attachment #8399809 - Flags: review?(felash)
Attachment #8399809 - Flags: review?(fabrice)
No longer depends on: tarako-marketplace
Blocks: 986178
Comment on attachment 8399809 [details] [review]
Fix MCC/MNC dual SIM detection in Marketplace app

r=me

checked the 2 ETags and the application, looks identical :)

I'm removing fabrice's request because he's in PTO and this looks to be urgent.
Attachment #8399809 - Flags: review?(felash)
Attachment #8399809 - Flags: review?(fabrice)
Attachment #8399809 - Flags: review+
Thanks Julien.  What are the next steps here?  Can you land the patch and close this bug?
I restarted Travis to try to have a green run, and then I can merge myself yep.

Adding a needinfo for now.
Flags: needinfo?(felash)
Component: Integration → Gaia
Product: Marketplace → Firefox OS
Target Milestone: 2014-03-04 → ---
Version: 1.5 → unspecified
Moved into Gaia just cause for the need for status flag tracking.
master: 5d81c713215ee1b97996e0bedff87dcd14309eec
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(felash)
Resolution: --- → FIXED
Please request approval-gaia-v1.3 on this when you feel it's ready for uplift.
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> Please request approval-gaia-v1.3 on this when you feel it's ready for
> uplift.

jsmith can you request that bit, please?
Comment on attachment 8399809 [details] [review]
Fix MCC/MNC dual SIM detection in Marketplace app

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 988677
[User impact] if declined: Incorrect detection of MCC/MNC in marketplace package.
[Testing completed]: QA verified by Krupa that MCC/MNC are correct with a DSDS device
[Risk to taking this patch] (and alternatives if risky): Low - the patch just updates the marketplace package to the latest one available hosted on marketplace with the MCC/MNC detection issue fixed. 
[String changes made]: None
Attachment #8399809 - Flags: approval-gaia-v1.3?(bbajaj)
Attachment #8399809 - Flags: approval-gaia-v1.3?(bbajaj) → approval-gaia-v1.3+
I'm not entirely sure how to get this uplifted to v1.3/v1.4.
Flags: needinfo?(cvan)
Keywords: branch-patch-needed
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #11)
> I'm not entirely sure how to get this uplifted to v1.3/v1.4.

https://github.com/mozilla-b2g/gaia/commit/5d81c713215ee1b97996e0bedff87dcd14309eec is the commit that needs to go in, that's all. Did you need something else?
Flags: needinfo?(cvan)
Yeah, it doesn't apply.
Flags: needinfo?(cvan)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> Yeah, it doesn't apply.

https://github.com/mozilla-b2g/gaia/commit/d1c10c8bbae0d81403dde107f6b6285c073da009 is the parent commit, and that's the only change we need.
Flags: needinfo?(cvan)
What Ryan is asking for here is he asking for a branch-specific patch of the same commit you generated for master. So all we need to do here is build the same exact patch for the 1.3 branch, 1.3T branch, and 1.4 branch.
Flags: needinfo?(cvan)
(In reply to Jason Smith [:jsmith] from comment #15)
> What Ryan is asking for here is he asking for a branch-specific patch of the
> same commit you generated for master. So all we need to do here is build the
> same exact patch for the 1.3 branch, 1.3T branch, and 1.4 branch.

Can someone with commit privileges do that? Julien?
Flags: needinfo?(cvan) → needinfo?(felash)
Chris, if you can send PR for the other branches I'll merge them.
Attached file V1.3 pull request — 
Hey Christopher,

can you have a look and check the package looks good?

I used -Xtheirs as a conflict resolver and took care to add the "origin" line back that was removed in bug 929602.
Attachment #8403139 - Flags: feedback?(cvan)
Flags: needinfo?(felash)
Attached file v1.4 pull request — 
Same for the v1.4 branch, except the "origin" line was already removed this time :)
Attachment #8403140 - Flags: feedback?(cvan)
Christopher, can you please have a look to these pull requests?
Flags: needinfo?(cvan)
Fabrice, feel free to merge if this looks good, I'd like someone to double check.
Flags: needinfo?(fabrice)
(In reply to Julien Wajsberg [:julienw] from comment #20)
> Christopher, can you please have a look to these pull requests?

Thank you, looks correct r+
Flags: needinfo?(cvan)
Comment on attachment 8403140 [details] [review]
v1.4 pull request

It's not clear to me if we need an approval to land on v1.4 for 1.3+ issues, and I checked the B2G landing page ;)

See comment 10 for the 1.3 approval request.
Attachment #8403140 - Flags: approval-gaia-v1.4?(bbajaj)
v1.3: 0182614ee33d1e274e97c08981157c0b97a5ba9e
status-b2g-v1.3: affected → fixed
Flags: needinfo?(fabrice)
Comment on attachment 8403140 [details] [review]
v1.4 pull request

from comment 22
Attachment #8403140 - Flags: feedback?(cvan) → feedback+
Comment on attachment 8403139 [details] [review]
V1.3 pull request

from comment 22
Attachment #8403139 - Flags: feedback?(cvan) → feedback+
Comment on attachment 8403140 [details] [review]
v1.4 pull request

1.3 blockers don't need approval to land on v1.4, per the landing guidelines. Please take some time to read them over and bookmark them for future reference.

https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_3

v1.4: https://github.com/mozilla-b2g/gaia/commit/8b8796a0d8adfd163fd72afa796f92c2947e1c67
Attachment #8403140 - Flags: approval-gaia-v1.4?(bbajaj)
yeah, I've read them carefully but I missed the part "uplift to: 1.4/aurora" that's in the v1.3 part... I think there should be a line about this in the v1.4 part as well. Bhavana, what do you think?

Ryan, thanks for merging!
Flags: needinfo?(bbajaj)
(In reply to Julien Wajsberg [:julienw] from comment #28)
> yeah, I've read them carefully but I missed the part "uplift to: 1.4/aurora"
> that's in the v1.3 part... I think there should be a line about this in the
> v1.4 part as well. Bhavana, what do you think?
> 
> Ryan, thanks for merging!

:julienw, updated the 1.4 section of the wiki for better understanding. Hope that helps.
Flags: needinfo?(bbajaj)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: