989731 - [E.me] Web app icon sizes and shadow are inconsistent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

inside collections: pinned cloud apps VS installed apps
in collection icons: cloud app 'added to top of collection' VS saved to homescreen and dragged into collection

see screenshots.

Comment 1

[Amir Nissim (:amirn)]

Attachment: inside collections

Comment 2

[Amir Nissim (:amirn)]

Attachment: on the homescreen

Comment 3

[Amir Nissim (:amirn)]

Test cases:
- cloud app added to "top of collection" VS native static apps in collection
- cloud app saved to homescreen from collection VS native apps on homescreen
- cloud app launched and saved as bookmark VS native apps on homescreen
- search results: webapps VS native apps VS download suggestions

Comment 4

[Amir Nissim (:amirn)]

Attachment: Pull Request

Comment 5

[Amir Nissim (:amirn)]

opened a separate bug #989983 for the homescreen collection icon discrepancy

Comment 6

[Cristian Rodriguez (:crdlc)]

Please, why don't you include unit tests? I guess that we have time to do it now, right?

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, can you suggest a unit test for this? Not sure how it should be done in this case.

Comment 8

[Cristian Rodriguez (:crdlc)]

When we were in Oslo working very hard as you know jeje, I remember that Evyatar started working on unit tests in ev.me but it seems to be discontinued because I don't see any unit tests in the code. To be honest, maybe, an unit test for this bug does not make sense but we should think of adding unit tests in ev.me part asap. Go ahead with this bug! But we have in mind this thought. Thanks guys

Comment 9

[Amir Nissim (:amirn)]

updated PR to fix shadow as well:
https://github.com/EverythingMe/gaia/commit/aed82e2757cac132fd960de94c72709fd97d79c1#diff-2

Ran, can you take another look please? (attaching screenshot)

Comment 10

[Amir Nissim (:amirn)]

Attachment: Before/After comparison

Comment 11

[Amir Nissim (:amirn)]

Attachment: screenshot-apps.png

reset device to get the new homescreen icons (see https://bugzilla.mozilla.org/show_bug.cgi?id=989876#c1)

also changed the text label shadow values to match homescreen's

Comment 12

[Amir Nissim (:amirn)]

PR updated and landed in master https://github.com/mozilla-b2g/gaia/commit/8138c8e

Comment 13

[Jason Smith [:jsmith]]

Polish, not a blocking issue.