989767 - When the tabbar is hidden (popup), the top border of the location bar is gone

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[henryfhchan]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140329030204

Steps to reproduce:

This is a regression with Australis.

Open a popup with toolbar=0.
The top border is gone.
This is due to chrome://browser/skin/browser.css Line 268.

> #nav-bar {
>  background-image: linear-gradient(rgba(253,253,253,0.45), rgba(255,255,255,0));
>  box-shadow: 0 1px 0 rgba(253,253,253,0.45) inset;
>  margin-top: -1px; /* Move up 1px into the TabsToolbar */


Patch
+#TabsToolbar:not([collapsed="true"]) + #nav-bar {
+    margin-top:-1px; /* Move up 1px into the TabsToolbar */
+}
 #nav-bar {
     background-image: linear-gradient(rgba(253,253,253,0.45), rgba(255,255,255,0));
     box-shadow: 0 1px 0 rgba(253,253,253,0.45) inset;
-    margin-top: -1px; /* Move up 1px into the TabsToolbar */

Comment 1

[henryfhchan]

Actually, shouldn't the negative margin be set on the tabbar instead of the navigation toolbar? This alternative approach avoids all the CSS **** in adding an additional margin or padding to items who protruded into the border...

Comment 2

[Tim Nguyen :ntim]

I don't clearly understand your issue. Can you provide a screenshot and some step to reproduce ? Thanks :)

Comment 3

[Tim Nguyen :ntim]

Ok, I now understand your issue.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for reporting. I have confirmed the issue.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I tested this on Windows. Do you think you could run it through your screenshot tool? I also moved the position:relative; and z-index:1; rules since they are only needed when the TabsToolbar is showing.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/7ede33d15218

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ede33d15218

Comment 8

[Andrei Vaida [:avaida]]

This issue is verified fixed on Nightly 31 2014-04-24 (Build ID: 20140424030204) using:
- Windows 7 64-bit [1],
- Windows 8.1 Pro 64-bit (Microsoft Surface Pro 2) [2],
- Ubuntu 14.04 LTS 32-bit [3],
- Mac OS X 10.9 [4].

1. Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:31.0) Gecko/20100101 Firefox/31.0
2. Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
3. Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
4. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0

Comment 9

[:Gijs (he/him)]

https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/idqLnBoyBsM

I suspect this is related. Jared, can you look into this?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

I don't see anything in the patch that would cause a regression, besides the style system having to do a tiny amount more of work by using the adjacent sibling selector.