Closed Bug 989825 Opened 6 years ago Closed 6 years ago

browser-syncui's _getAppName has broken code that tries to retrieve defaultAccountApplication string

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

"brandName" is undefined at http://hg.mozilla.org/mozilla-central/annotate/0e19655e93df/browser/base/content/browser-syncui.js#l257, so the bit inside the block will always throw AFAICT.

I think this doesn't matter too much because this was meant as a mechanism for Metro to have a different appname, and this code doesn't run on Metro.
Yeah, this was Bug 826357.
Depends on: 826357
Bug 908461 is what added the dead code, though.
Blocks: 908461
No longer depends on: 826357
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8402053 - Flags: review?(rnewman)
Attachment #8402053 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/7a915afcb0d4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.