Closed
Bug 989825
Opened 10 years ago
Closed 10 years ago
browser-syncui's _getAppName has broken code that tries to retrieve defaultAccountApplication string
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
1.20 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
"brandName" is undefined at http://hg.mozilla.org/mozilla-central/annotate/0e19655e93df/browser/base/content/browser-syncui.js#l257, so the bit inside the block will always throw AFAICT. I think this doesn't matter too much because this was meant as a mechanism for Metro to have a different appname, and this code doesn't run on Metro.
Assignee | ||
Comment 2•10 years ago
|
||
Bug 908461 is what added the dead code, though.
Assignee | ||
Comment 3•10 years ago
|
||
Updated•10 years ago
|
Attachment #8402053 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7a915afcb0d4
Target Milestone: --- → Firefox 31
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a915afcb0d4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•