989829 - Move all APZ prefs into gfxPrefs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

gfxPrefs.h is nice, we should use it more.

Comment 1

[Botond Ballo [:botond]]

Comment on attachment 8399163 [details] [diff] [review]
Patch

Review of attachment 8399163 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +217,5 @@
> + * velocity is above gMinSkateSpeed). We prefer to increase the size of the
> + * Y axis because it is more natural in the case that a user is reading a page
> + * that scrolls up/down. Note that one, both or neither of these may be used
> + * at any instant.
> + * In general we want g[XY]SkateSizeMultiplier to be smaller than the corresponding

s/g[XY]SkateSizeMultiplier/apx.[xy]_skate_size_multiplier

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Fixed. Also fixed a couple of other gXXX references in the documentation. Landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5e6cd1cc9c

Comment 3

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/76b0c0037a76 for asserting like https://tbpl.mozilla.org/php/getParsedLog.php?id=36980111&tree=Mozilla-Inbound

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I forgot to update the gtests to use the pref-initializing test fixture. Pretty trivial change and I tested it locally to make sure it works, so I updated and relanded:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c938a277aa6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c938a277aa6