989892 - fix test_call_log_all_calls.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Buri
Gaia      4cf7ec04b82320a1ff1f825220204f454f951a87
Gecko     https://hg.mozilla.org/mozilla-central/rev/1c23863d8dda
BuildID   20140330160201
Version   31.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_call_log_all_calls.py", line 35, in test_call_log_all_calls
self.assertTrue(call_log.is_all_calls_tab_selected)
AssertionError: False is not true

Comment 1

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 17795

Comment 2

[[:AndreiH]]

Comment on attachment 8399254 [details] [review]
PR 17795

_all_calls_tab_locator is only used here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/phone/regions/call_log.py#L19

Let's change that locator also to "all_calls_tab_link_locator" and get delete it afterwards

Comment 3

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8399254 [details] [review]
PR 17795

Updated.

Comment 4

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/dfe1f40f50bdb6bb599cf3f25471951d2d7166fd