989971 - "More" search results aren't still available when hitting back.

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Stuart Colville [:muffinresearch]]

STR:

* Go to -dev marketplace
* From homepage scroll to bottom of results
* Click more 
* Scroll down and click the details page of the app noting the scroll position.
* From the details page hit the back button in the app


What happens: 

* You end up at the bottom of the first page of results (with the more button visible) 

What should happen:

* You should return to the point in the page where you were when you clicked through to the details page.

This used to work and the previous results page complete with the extra content loaded via the "more" button used to be available.

Comment 1

[Stuart Colville [:muffinresearch]]

Doesn't happen on prod

Comment 2

[Stuart Colville [:muffinresearch]]

Bisecting the commits points to https://github.com/mozilla/fireplace/commit/076871afe6109c111a5f8227b0c52bbcec9c4372 being the commit that introduced this issue.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Stuart Colville [:scolville] from comment #2)
> Bisecting the commits points to
> https://github.com/mozilla/fireplace/commit/
> 076871afe6109c111a5f8227b0c52bbcec9c4372 being the commit that introduced
> this issue.

Are you positively sure that's the right commit?

I would think it'd be https://github.com/mozilla/fireplace/commit/51c372a0 but I haven't bisected myself.

Thanks for catching this, Stuart. I really do wish we caught this way earlier in the week though :\

Comment 4

[krupa raj[:krupa]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> (In reply to Stuart Colville [:scolville] from comment #2)
> > Bisecting the commits points to
> > https://github.com/mozilla/fireplace/commit/
> > 076871afe6109c111a5f8227b0c52bbcec9c4372 being the commit that introduced
> > this issue.
> 
> Are you positively sure that's the right commit?
> 
> I would think it'd be https://github.com/mozilla/fireplace/commit/51c372a0
> but I haven't bisected myself.
> 
> Thanks for catching this, Stuart. I really do wish we caught this way
> earlier in the week though :\

I agree. https://bugzilla.mozilla.org/show_bug.cgi?id=983815 was marked as [qa-]. So, I won't feel too terrible about it :)

Comment 5

[Wil Clouser [:clouserw]]

based on those commits, I assume -> cvan

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/39c270a

My bad - forgot about the "More results" button. When you clicked the "More results" button, fireplace already had the model data in the model cache, so it didn't even try to fetch the XHR from the request cache. But when you navigated away and came back, fireplace tried to use the request cache, and because the "More Results" button was pointing to our API instead of our CDN for the results, fireplace got confused and gave up. Thanks, everyone!

Comment 7

[Iulian Timis]

Issue is still reproducing in https://marketplace-dev.allizom.org/ on FF31 (Win 7) and MP-dev app (FF OS).
Scroll is not preserved after going back from app details page.
Please see screencast for Win 7 http://screencast.com/t/wdxB7oEG4

Comment 8

[Stuart Colville [:muffinresearch]]

(In reply to Iulian Timis from comment #7)
> Issue is still reproducing in https://marketplace-dev.allizom.org/ on FF31
> (Win 7) and MP-dev app (FF OS).
> Scroll is not preserved after going back from app details page.
> Please see screencast for Win 7 http://screencast.com/t/wdxB7oEG4

It's working for me in Nightly OSX and FFOS 1.2 Inari.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

I'm also doing exactly what you're doing in the screencast and I cannot reproduce. Can you make sure you refreshed the assets in your browser? I don't know what to say. Can you try again?

Comment 10

[Iulian Timis]

I have tried on a new profile but I was not able to reproduce http://screencast.com/t/z40rbXqilw 
It's working properly on FF OS also.