990021 - [Messages] We should show the correct error message when trying to download a MMS in airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

We need to display a different message for RadioDisabledError in the MMS retrieving case.

+++ This bug was initially created as a clone of Bug #981577 +++

STR:
* set "MMS Automatic retrieval" to off
* receive a MMS with attachment
* enable airplane mode
* try to download the MMS

Expected:
* we should see an error related to airplane mode

Actual:
* no error is displayed, only the error icon is added.

Note that I didn't find any error message related to airplane mode for this case (we have one for _sending_ messages but it's not suited for this bug).

NI ayman for providing more information.
QAwanted to know the behavior in v1.1.

Comment 1

[Julien Wajsberg [:julienw]]

NI Joe because we need to prioritize this in the 1.5 time frame.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

1.5? so this can be triaged in comms team triage

Comment 3

[howie [:howie]]

Change component to SMS, if it's not correct, please assign back or assign to correct component, thanks.

Comment 4

[Julien Wajsberg [:julienw]]

Yes, it's a SMS issue, Gecko part was done in Bug 981577.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

triage: add to backlog
ni? Omega for the spec

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

Let's use this:

Airplane Mode Activated
-----------------------
Turn off airplane mode to download attachments.

[OK]

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Omega,
Do you have other strings to notify user instead of guiding them to turning off airplane mode?

Comment 8

[Omega Feng [:Omega] [:馮於懋]]

(In reply to Wesley Huang [:wesley_huang] from comment #7)
> Hi Omega,
> Do you have other strings to notify user instead of guiding them to turning
> off airplane mode?

I suggest this string since we have similar string when sending MSG with Airplane mode on. It's "Turn off airplane mode to send messages.". If we want to change the string, we should consider both of them. No idea for now. Anybody has suggestions?

Comment 9

[Julien Wajsberg [:julienw]]

I think that when Airplane mode is enabled, the user will know how to disable it.

Comment 10

[Oleg Zasypkin [:azasypkin]]

Hey Omega and Julien,

Currently I see the following message for the STR in comment 0:

Title: "Airplane mode activated"
Body: "Turn off airplane mode to send messages." - still a bit weird, as we're not sending anything, but retrieving.

Should we just replace "send message" part with "download message" or there are any other ideas?

Thanks!

Comment 11

[Oleg Zasypkin [:azasypkin]]

Please, see comment 10...

Comment 12

[Julien Wajsberg [:julienw]]

See comment 6 :)

Comment 13

[Oleg Zasypkin [:azasypkin]]

Nice, thanks!

Comment 14

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Steve,

I have the patch for this for a long time already, but was waiting for bug 1035279 to be resolved, so the time to dust off this code has come :)

Thanks!

Comment 15

[Steve Chung [:steveck]]

Patch looks fine for me but I haven't got a validate sim for testing yet, will try it other day. Thanks!

Comment 16

[Steve Chung [:steveck]]

Comment on attachment 8465283 [details] [review]
GitHub pull request URL

Thanks for adding new error message for this case. I think we just need additional comment for this, so r=me.

Comment 17

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #16)
> Comment on attachment 8465283 [details] [review]
> GitHub pull request URL
> 
> Thanks for adding new error message for this case. I think we just need
> additional comment for this, so r=me.

Thanks for review! Added comment as you suggested.

Master: https://github.com/mozilla-b2g/gaia/commit/9d6c9c846721d9f7ff44c5f1421fb202e1d0b640