Closed
Bug 990065
Opened 10 years ago
Closed 10 years ago
Screen rotation feature is broken in packaged b2g desktop
Categories
(Firefox OS Graveyard :: Simulator, defect)
Firefox OS Graveyard
Simulator
Tracking
(firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
1.4 S6 (25apr)
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 2 obsolete files)
3.01 KB,
patch
|
ochameau
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
SimulatorScreen.js is missing in package-manifest.in, so that this recently added xpcom isn't added in b2g tarball. It ends up working in local builds, but not once released in packages...
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8399488 -
Flags: review?(21)
Comment 2•10 years ago
|
||
Comment on attachment 8399488 [details] [diff] [review] Ensure shipping simulator screen xpcom in b2g desktop package Review of attachment 8399488 [details] [diff] [review]: ----------------------------------------------------------------- Sigh.
Attachment #8399488 -
Flags: review?(21) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65338f03492b
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Either this or bug 990057 made B2G desktop mochitests perma-fail. I backed both out for investigation. https://hg.mozilla.org/integration/mozilla-inbound/rev/05792ab1e06f https://tbpl.mozilla.org/php/getParsedLog.php?id=37084445&tree=Mozilla-Inbound
Assignee | ||
Comment 5•10 years ago
|
||
Let's check if that's really failing because of these patches: https://tbpl.mozilla.org/?tree=Try&rev=a98f149fc65e
Comment 6•10 years ago
|
||
The following changesets are now in Firefox Nightly: > 65338f03492b Bug 990065 - Ensure shipping simulator screen xpcom in b2g desktop package. r=vingtetun > 05792ab1e06f Backed out changeset 65338f03492b (bug 990065) and changeset 8c3b772518f2 (bug 990057) for B2G desktop mochitest failures. Nightly Build Information: ID: 20140402030201 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6 Version: 31.0a1 TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786 URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central Download Links: > Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2 > Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2 > Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2 > Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg > Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe > Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe Previous Nightly Build Information: ID: 20140401030203 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4 Version: 31.0a1 TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8 URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
Assignee | ||
Comment 7•10 years ago
|
||
I can't believe it is introducing such regression, but out of these two bug, I would most likely due to this one that is actually loaded into b2g desktop. The other is only shiped in simulator addon, that is never loaded in tests (so far).
Assignee | ||
Comment 8•10 years ago
|
||
Ship simulator screen xpcom in b2g desktop package and also prevent it from breaking bfcache... The xpcom was listener for unload event... which prevent bfcache to work... And the shared worker mochitest was relying on bfcache to work. So use observer notification instead. https://tbpl.mozilla.org/?tree=Try&rev=f2c65186eebb
Attachment #8399488 -
Attachment is obsolete: true
Attachment #8404045 -
Flags: review?(21)
Comment 9•10 years ago
|
||
Comment on attachment 8404045 [details] [diff] [review] patch Review of attachment 8404045 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch. ::: b2g/components/SimulatorScreen.js @@ +108,5 @@ > > case 'simulator-orientation-change': > this._windows.forEach(fireOrientationEvent); > break; > } nit: You may consider a local |let windows = this._windows;| at the beginning of the switch.
Attachment #8404045 -
Flags: review?(21) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8404045 -
Attachment is obsolete: true
Attachment #8404058 -
Flags: review+
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/e1c19ed25b12
Keywords: checkin-needed
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e1c19ed25b12
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8404058 [details] [diff] [review] patch See bug 976773 comment 30. We would like to build 1.4 simulators and need to uplift mostly desktop-specific patches. This patch modify only desktop codepath.
Attachment #8404058 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8404058 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 15•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fd8d8f9d167
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → fixed
status-firefox31:
--- → fixed
Target Milestone: 2.0 S1 (9may) → 1.4 S6 (25apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•