Closed Bug 990065 Opened 6 years ago Closed 6 years ago

Screen rotation feature is broken in packaged b2g desktop


(Firefox OS Graveyard :: Simulator, defect)

Not set


(firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

1.4 S6 (25apr)
Tracking Status
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed


(Reporter: ochameau, Assigned: ochameau)




(1 file, 2 obsolete files)

SimulatorScreen.js is missing in, so that this recently added xpcom isn't added in b2g tarball. It ends up working in local builds, but not once released in packages...
Comment on attachment 8399488 [details] [diff] [review]
Ensure shipping simulator screen xpcom in b2g desktop package

Review of attachment 8399488 [details] [diff] [review]:

Attachment #8399488 - Flags: review?(21) → review+
Keywords: checkin-needed
Blocks: 976773
Let's check if that's really failing because of these patches:
The following changesets are now in Firefox Nightly:

> 65338f03492b Bug 990065 - Ensure shipping simulator screen xpcom in b2g desktop package. r=vingtetun
> 05792ab1e06f Backed out changeset 65338f03492b (bug 990065) and changeset 8c3b772518f2 (bug 990057) for B2G desktop mochitest failures.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1

Download Links:

>         Linux x86:
>      Linux x86_64:
> Linux x86_64 ASAN:
>               Mac:
>             Win32:
>             Win64:

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
I can't believe it is introducing such regression, but out of these two bug, I would most likely due to this one that is actually loaded into b2g desktop. The other is only shiped in simulator addon, that is never loaded in tests (so far).
Attached patch patch (obsolete) — Splinter Review
Ship simulator screen xpcom in b2g desktop package and also prevent it from breaking bfcache...

The xpcom was listener for unload event... which prevent bfcache to work...
And the shared worker mochitest was relying on bfcache to work.
So use observer notification instead.
Attachment #8399488 - Attachment is obsolete: true
Attachment #8404045 - Flags: review?(21)
Comment on attachment 8404045 [details] [diff] [review]

Review of attachment 8404045 [details] [diff] [review]:

Nice catch.

::: b2g/components/SimulatorScreen.js
@@ +108,5 @@
>        case 'simulator-orientation-change':
>          this._windows.forEach(fireOrientationEvent);
>          break;
>      }

nit: You may consider a local |let windows = this._windows;| at the beginning of the switch.
Attachment #8404045 - Flags: review?(21) → review+
Attached patch patchSplinter Review
Attachment #8404045 - Attachment is obsolete: true
Attachment #8404058 - Flags: review+
Green try.
Keywords: checkin-needed
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
Comment on attachment 8404058 [details] [diff] [review]

See bug 976773 comment 30.
We would like to build 1.4 simulators and need to uplift mostly desktop-specific patches.

This patch modify only desktop codepath.
Attachment #8404058 - Flags: approval-mozilla-aurora?
Attachment #8404058 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.