Closed Bug 990160 Opened 6 years ago Closed 5 years ago

Cycle collect nsCSSRuleProcessor

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 508725 added a field mScopeElement, so maybe this class should be cycle collected now.  I think if this is an element of an XBL document, it will own an nsXBLDocumentInfo, which creates a cycle through nsXBLPrototypeBinding to nsXBLPrototypeResources which holds an nsIStyleRuleProcessor.

I'm going to see how far I can get with a patch to do this without knowing anything about these classes.
So was the thing added for the same thing blink is now possibly removing?
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/R1x18ZLS5qQ

Does IE support it? What about WebKit?
This at least sort of works.
Assignee: nobody → continuation
Comment on attachment 8399648 [details] [diff] [review]
Cycle collect nsCSSRuleProcessor. WIP

This doesn't add any traversals of it.  The only use of it I can see in a CCed class is nsXBLPrototypeResources, which William is setting up in the bug this bug is blocking.  There's also a strong reference from an nsStyleSet, but that class is not cycle collected.
Attachment #8399648 - Flags: review?(bzbarsky)
Version: 24 Branch → Trunk
Comment on attachment 8399648 [details] [diff] [review]
Cycle collect nsCSSRuleProcessor. WIP

r=me
Attachment #8399648 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
Summary: Investigate cycle collecting nsCSSRuleProcessor → Cycle collect nsCSSRuleProcessor
https://hg.mozilla.org/mozilla-central/rev/99d86357d4fd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment on attachment 8399648 [details] [diff] [review]
Cycle collect nsCSSRuleProcessor. WIP

Approval Request Comment
[Feature/regressing bug #]: Bug 806506
[User impact if declined]: Potential memory leak in B2G certified apps.  Needed for bug 1025738.
[Describe test coverage new/current, TBPL]: this code is exercised quite a bit in the browser
[Risks and why]: should be low risk, as the patch is simple and is heavily exercised
[String/UUID change made/needed]: none
Attachment #8399648 - Flags: approval-mozilla-aurora?
Comment on attachment 8399648 [details] [diff] [review]
Cycle collect nsCSSRuleProcessor. WIP

Aurora+
Attachment #8399648 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.