Closed
Bug 990243
Opened 10 years ago
Closed 10 years ago
Use a background color instead of a background image for the download / install phase of the stub installer
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
(Whiteboard: [stubv2=])
Attachments
(2 files, 1 obsolete file)
1.04 MB,
image/png
|
robert.strong.bugs
:
ui-review+
|
Details |
17.96 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
This will approximately lessen the size of the stub installer | With | Without | Reduction | --------+--------+---------+--------------+ Release | 276 KB | 231 KB | 45 KB (16%) | Nightly | 668 KB | 472 KB | 196 KB (29%) |
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8399627 -
Flags: ui-review?(philipp)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8399634 -
Flags: review?(netzen)
Comment 4•10 years ago
|
||
Comment on attachment 8399634 [details] [diff] [review] patch rev1 Review of attachment 8399634 [details] [diff] [review]: ----------------------------------------------------------------- Awesome :)
Attachment #8399634 -
Flags: review?(netzen) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Missed one removal of bgplain.bmp from a Makefile. Carrying forward r+
Attachment #8399634 -
Attachment is obsolete: true
Attachment #8400145 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8399627 [details]
screenshot comparison with and without an image for the background
I asked shorlander to look at this change over irc
<shorlander> rstrong: looks good to me
I'm going to take that as ui-review+
Attachment #8399627 -
Flags: ui-review?(philipp) → ui-review+
Assignee | ||
Comment 7•10 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/cb6437e9b231
Flags: in-testsuite-
Target Milestone: --- → Firefox 31
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb6437e9b231
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
Actual size reduction numbers for Nightly | With | Without | Reduction | --------+--------+---------+--------------+ Nightly | 673 KB | 502 KB | 171 KB (25%) | Not as good as my local builds but still significant.
You need to log in
before you can comment on or make changes to this bug.
Description
•