Closed Bug 990248 Opened 6 years ago Closed 6 years ago

make mozilla::pkix the default certificate verifier in Firefox Nightly

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: keeler, Assigned: keeler)

References

Details

Attachments

(1 file)

From bug 915930:
(In reply to Camilo Viecco (:cviecco) from comment #7)
> Comment on attachment 8399611 [details] [diff] [review]
> patch
> 
> Review of attachment 8399611 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why dont we make another bug (with this patch) to enable mozilla::pkix in
> firefox(only) and leave this when we what to have all products with it as
> default? (when we actually change the value in nsNSSComponent)
Attached patch patchSplinter Review
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8399633 - Flags: review?(cviecco)
Attachment #8399633 - Flags: feedback?(brian)
Attachment #8399633 - Flags: review?(cviecco) → review+
Comment on attachment 8399633 [details] [diff] [review]
patch

Review of attachment 8399633 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1366,5 @@
>  pref("security.mixed_content.block_active_content", true);
>  
> +#ifndef RELEASE_BUILD
> +pref("security.use_mozillapkix_verification", true);
> +#endif

I don't think we should have the conditional on RELEASE_BUILD here. If we decide not to leave it enabled then we'll make that decision when the code is about to hit beta/release and we'll write a patch (or hopefully not) to do it, just like anything else.

Note that this patch will cause the pref to show up in about:config.
Attachment #8399633 - Flags: feedback?(brian) → review+
Ok - I took off the conditional on RELEASE_BUILD before pushing.
https://hg.mozilla.org/integration/mozilla-inbound/rev/50ff5b820452
https://hg.mozilla.org/mozilla-central/rev/50ff5b820452
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 991144
Depends on: 1018876
You need to log in before you can comment on or make changes to this bug.