990260 - httpd should allow one to create example.com

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I may be incorrect, but it seems as though httpd only allows one to create a `http://localhost:xyz` domain to test the http protocol, and it would be nice if we could use this module to create a fake `example.com` url in many cases.  For instance some add-ons like about:history and lightbeam explicitly ignore all requests to localhost.

Comment 1

[:xKhorasan]

I am interested in using sdk/test/httpd module to create fake 'example.com' URL, so investigated sdk/test/httpd module code.
From looking at the code, I found that we only have to add server identity after created nsHttpServer instance to create fake 'example.com' URL like following:

    const { startServerAsync } = require("sdk/test/httpd");
    const srv = startServerAsync(8099);
    srv.indentity.add("http", "example.com", 80);

Here I wrote a test case for creating fake domain URL using sdk/test/httpd module:
https://github.com/xKerman/addon-sdk/commit/20ecbf8ef88ce64add34d781a8914f40f31ace84

I think just doing |srv.indentity.add("http", "example.com", 80);| is enough to solve this bug, so we can close this bug.
Does this make sense?

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Irakli will have to approve api changes like this.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I don't have any problems with this changes, it's just a thing we use for tests anyway.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

This is a 3rd party module now and not shipped with firefox.