990268 - mStatus is not sent from FTPChannelParent to FTPChannelChild

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Steve Workman [:sworkman] (INACTIVE)]

Follow-up from 985230.

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

Attachment: v1.0 Send FTPChannelParent::mStatus in IPDL messages to FTPChannelChild

No r? yet; waiting on try results:
https://tbpl.mozilla.org/?tree=Try&rev=b8f60e5c2d9f

Comment 2

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8400171 [details] [diff] [review]
v1.0 Send FTPChannelParent::mStatus in IPDL messages to FTPChannelChild

Honza, this is a follow up to bug 985230; Basically, mStatus in HttpChannelChild was not in sync with mStatus in HttpChannelParent. Jason worked on the previous patch for HTTP, and this is the follow up for FTP. Please take a look.

The idea is to send mStatus with SendOnStart and SendOnData, just as Jason's patch did with HTTP. There are also some style changes - some prototypes were being changed anyway, so it makes sense to me to clean them up a bit and make them easier to change next time.

Let me know what you think. Thanks!

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8400171 [details] [diff] [review]
v1.0 Send FTPChannelParent::mStatus in IPDL messages to FTPChannelChild

Review of attachment 8400171 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/ftp/FTPChannelChild.cpp
@@ +226,5 @@
>  
>  class FTPStartRequestEvent : public ChannelEvent
>  {
> +public:
> +  FTPStartRequestEvent(FTPChannelChild* aChild, const nsresult& aChannelStatus,

maybe const nsresult& aChannelStatus, on a new line too?

Comment 4

[Steve Workman [:sworkman] (INACTIVE)]

(In reply to Honza Bambas (:mayhemer) from comment #3)
> Comment on attachment 8400171 [details] [diff] [review]
> v1.0 Send FTPChannelParent::mStatus in IPDL messages to FTPChannelChild
> 
> Review of attachment 8400171 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: netwerk/protocol/ftp/FTPChannelChild.cpp
> @@ +226,5 @@
> >  
> >  class FTPStartRequestEvent : public ChannelEvent
> >  {
> > +public:
> > +  FTPStartRequestEvent(FTPChannelChild* aChild, const nsresult& aChannelStatus,
> 
> maybe const nsresult& aChannelStatus, on a new line too?

Yeah - I pretty much just went with what clang-format suggested with that patch, but it didn't look right. Fixed that and the other two event classes.

https://hg.mozilla.org/integration/mozilla-inbound/rev/32c1e7286364

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32c1e7286364