Closed Bug 990298 Opened 10 years ago Closed 10 years ago

testJSWindowCreationAndSwitching is failing

Categories

(Remote Protocol :: Marionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: automatedtester, Assigned: automatedtester)

References

Details

Attachments

(1 file, 1 obsolete file)

testJSWindowCreationAndSwitching is failing once added to the test manifest. we need to fix this
TEST-START test_window_switching.py
testJSWindowCreationAndSwitching (test_window_switching.TestWindowSwitching) ... ERROR

======================================================================
ERROR: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/marionette_test.py", line 191, in run
    self.tearDown()
  File "/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_window_switching.py", line 47, in tearDown
    self.marionette.close(handle)
TEST-UNEXPECTED-FAIL | test_window_switching.py test_window_switching.TestWindowSwitching.testJSWindowCreationAndSwitching | TypeError: close() takes exactly 1 argument (2 given)
----------------------------------------------------------------------
No longer blocks: 811796
Depends on: 811796
try is green
Attached patch Correcting window switching test (obsolete) — Splinter Review
Attachment #8400570 - Flags: review?(jgriffin)
Assignee: nobody → dburns
Status: NEW → ASSIGNED
Comment on attachment 8400570 [details] [diff] [review]
Correcting window switching test

Review of attachment 8400570 [details] [diff] [review]:
-----------------------------------------------------------------

The B2G try run is failing; we should still add this to the manifest for desktop jobs with 'b2g = false', I think.
Attachment #8400570 - Flags: review?(jgriffin) → review-
The failure wasnt related to this. I have raised bug 991242 and will fix there
Attachment #8403509 - Flags: review?(jgriffin)
Attachment #8400570 - Attachment is obsolete: true
Comment on attachment 8403509 [details] [diff] [review]
Correcting window switching test

Review of attachment 8403509 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8403509 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/86f28454cc50
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: