990305 - Move IsInEmulator() from GrallocImage to gfxPlatform

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #985772 +++

In Bug 985772, gonk emulator check function is added to GrallocImage. It seems better to move to gfxPlatform.

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#52

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Move IsInEmulator() from GrallocImage to gfxPlatform

Comment 2

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=24ecf3377558

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> https://tbpl.mozilla.org/?tree=Try&rev=24ecf3377558

attachment 8399796 [details] [diff] [review] regress camera test. It blocks GrallocImage() creation for YCbCr. On emulator, camera hal does not use this format, but using RGB gralloc. On emulator there is a inconsistency to the format. But at least works. attachment 8399796 [details] [diff] [review] breaks it.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Move IsInEmulator() from GrallocImage to gfxPlatform

Fix camera preview problem.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=c2e492da782c

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8399900 [details] [diff] [review]
patch v2 - Move IsInEmulator() from GrallocImage to gfxPlatform

Carry "r=nical".

Comment 7

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c57d9bf41ac4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c57d9bf41ac4

Comment 9

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> c57d9bf41ac4 Bug 990305 - Move IsInEmulator() from GrallocImage to gfxPlatform r=nical

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central