Closed Bug 990305 Opened 7 years ago Closed 7 years ago

Move IsInEmulator() from GrallocImage to gfxPlatform

Categories

(Core :: Graphics: Layers, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #985772 +++

In Bug 985772, gonk emulator check function is added to GrallocImage. It seems better to move to gfxPlatform.

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#52
Assignee: nobody → sotaro.ikeda.g
Attachment #8399796 - Flags: review?(nical.bugzilla)
Attachment #8399796 - Flags: review?(nical.bugzilla) → review+
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> https://tbpl.mozilla.org/?tree=Try&rev=24ecf3377558

attachment 8399796 [details] [diff] [review] regress camera test. It blocks GrallocImage() creation for YCbCr. On emulator, camera hal does not use this format, but using RGB gralloc. On emulator there is a inconsistency to the format. But at least works. attachment 8399796 [details] [diff] [review] breaks it.
Fix camera preview problem.
Attachment #8399796 - Attachment is obsolete: true
Comment on attachment 8399900 [details] [diff] [review]
patch v2 - Move IsInEmulator() from GrallocImage to gfxPlatform

Carry "r=nical".
Attachment #8399900 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/c57d9bf41ac4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
The following changeset is now in Firefox Nightly:

> c57d9bf41ac4 Bug 990305 - Move IsInEmulator() from GrallocImage to gfxPlatform r=nical

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
You need to log in before you can comment on or make changes to this bug.