990473 - missing next button in <input type='number' >

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[gillesseerden]

Attachment: Screenshot_firefox.png

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36

Steps to reproduce:

Simple html form with <input type="number">. 

https://support.mozilla.org/en-US/questions/991970


Actual results:

On a nexus 7, the virtual keyboard does not display a "next" button as it does with <input type="text">


Expected results:

On a nexus 7, the virtual keyboard does display a "next" button in Chrome, Mobile Safari.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Check parent input for action hint if focus is in anonymous subtree (v1)

A "number" input contains anonymous child nodes including the number field and the up/down spinner. If the focus is in the anonymous subtree, we should check the top-level input (i.e. the binding parent) for the action hint.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8456433 [details] [diff] [review]
Check parent input for action hint if focus is in anonymous subtree (v1)

LGTM. But I'm not sure if this works fine with XUL element.

Smaug, do you have some idea about this?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8456433 [details] [diff] [review]
Check parent input for action hint if focus is in anonymous subtree (v1)

>+    nsIContent* inputContent = aContent->IsInAnonymousSubtree() ?
>+                               aContent->GetBindingParent() : aContent;
>+
You could do
nsIContent* inputContent = aContent->FindFirstNonChromeOnlyAccessContent()
That would be even more correct, since IsInAnonymousSubtree deals with non-native anonymous content too.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Made the change to FindFirstNonChromeOnlyAccessContent().

https://hg.mozilla.org/integration/mozilla-inbound/rev/4571dc040857

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4571dc040857