990482 - [Camera][UX] Swipe gesture should work on camera mode switcher

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Attachment: bugSwitcher.MOV

It feels wrong having a switcher that doesn't detects swipes. It happened to me and observed several people trying to swipe on the switcher (see attached video)

Comment 1

[Diego Marcos [:dmarcos]]

Rob, what do you think?

Comment 2

[Rob MacDonald [:robmac]]

(In reply to Diego Marcos [:dmarcos] from comment #1)
> Rob, what do you think?

Totaly agree.

Comment 3

[Rob MacDonald [:robmac]]

typo - "totally" ;)

Comment 4

[Rob MacDonald [:robmac]]

(or "totes" as they would say in the Bay Area.)

Comment 5

[Hema Koka [:hema]]

Wilson, please take a look after other blockers are fixed

Comment 6

[Wilson Page [:wilsonpage]]

Agree, this is a 'nice to have', but *not* trivial to implement. Right now we have far more important stuff to deal with.

Comment 7

[Wilson Page [:wilsonpage]]

Discussed with dmarcos, this should not block Madai.

Comment 8

[Tiffanie Shakespeare [:tif]]

Any possibility it could be done for this release?

Comment 9

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Could still do with a bit of transition polish. But definitely an improvement on what we currently have.

Comment 10

[Diego Marcos [:dmarcos]]

You cannot imagine how happy this makes me :). This kind of attention to the detail is what makes user fall in love. 

First piece of feedback:

The icon underneath the button is not showed until you complete the drag. It should be visible all the time. Also when you don't use the drag and just tap there's no animation of the button going to the new position.

Starting to lool at the code now.

Comment 11

[Diego Marcos [:dmarcos]]

Another piece of feedback. Can we make the target bigger? Now it's difficult to grab the button

Comment 12

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8439364 [details] [review]
pull-request (master)

I agree with Diego's comments about the icon being hidden and the animation being the same for both tap and drag. That would be really cool.

How big is the target area now?

Adding Amy to also take a look.

Comment 13

[Amy Lee [:amylee] UX]

Comment on attachment 8439364 [details] [review]
pull-request (master)

I agree that the animation should be the same for tap and drag. I was just wondering how it would look if the camera icon faded out as you dragged it to the video recorder? Or if the circle stretched out to the video recorder as you dragged it like how the unlock toggle functions? I know the 2nd idea might be more effort than it's worth but I was just thinking of having some sort of consistency with our animations. Even if we just had the icon fade out, it would be similar to how our unlock screen toggle fades out when you drag it.

Comment 14

[Wilson Page [:wilsonpage]]

Comments addressed:

- Icons always below switch head
- Slide transitions added
- Icons fade between 'picture' and 'video' when dragging
- Switch handle hit-area increased by 10px on each side

Comment 15

[Diego Marcos [:dmarcos]]

It looks great! 

Visual feedback:

- I'm not a big fan of the fade between icons. When you see the two icons overlapping looks weird, like a graphical glitch rather than something intentional.

- The button animation when tapping (not sliding) is a bit too slow. I would make it faster

- We currently persist the camera mode and I'm not sure if it's a good idea. The most common scenario is the user pulling the phone from the pocket to take a picture. Keeping always the picture as the mode when opening the camera captures better the user intent.

Comment 16

[Diego Marcos [:dmarcos]]

Comment on attachment 8439364 [details] [review]
pull-request (master)

Conditional r+:

- Missing unit test for the drag module
- Made some suggestions on github comments.

Comment 17

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8439364 [details] [review]
pull-request (master)

I think Diego is right on again - the overlap of the two icons seems a bit weird. Should we fade one out before fading in the next?

I've noticed that other cameras do a hybrid for mode persistence. Diego, can you open a bug to look more into this behaviour and I can take a look into it more. 

I think for the original intent of the bug, Wilson has done a good job. I'll leave it to Amy to make final comments on the transitions.

Comment 18

[Amy Lee [:amylee] UX]

(In reply to Tiffanie Shakespeare from comment #17)
> Comment on attachment 8439364 [details] [review]
> pull-request (master)
> 
> I think Diego is right on again - the overlap of the two icons seems a bit
> weird. Should we fade one out before fading in the next?
> 
> I've noticed that other cameras do a hybrid for mode persistence. Diego, can
> you open a bug to look more into this behaviour and I can take a look into
> it more. 
> 
> I think for the original intent of the bug, Wilson has done a good job. I'll
> leave it to Amy to make final comments on the transitions.

I think the transition looks okay when you tap on the video icon and it slides over since the transition is quick enough that you don't notice the overlap. But it does look a bit weird when you move it over slowly. Wilson, can you make the video record fade in a bit later and the camera fade out sooner so there is less of an overlap between the transition? Thanks!

Comment 19

[Amy Lee [:amylee] UX]

(In reply to Amy Lee [:amylee] from comment #18)
> (In reply to Tiffanie Shakespeare from comment #17)
> > Comment on attachment 8439364 [details] [review]
> > pull-request (master)
> > 
> > I think Diego is right on again - the overlap of the two icons seems a bit
> > weird. Should we fade one out before fading in the next?
> > 
> > I've noticed that other cameras do a hybrid for mode persistence. Diego, can
> > you open a bug to look more into this behaviour and I can take a look into
> > it more. 
> > 
> > I think for the original intent of the bug, Wilson has done a good job. I'll
> > leave it to Amy to make final comments on the transitions.
> 
> I think the transition looks okay when you tap on the video icon and it
> slides over since the transition is quick enough that you don't notice the
> overlap. But it does look a bit weird when you move it over slowly. Wilson,
> can you make the video record fade in a bit later and the camera fade out
> sooner so there is less of an overlap between the transition? Thanks!

Just loaded the patch with Wilson's revised transition. I think it looks better now with the quicker fade. Tiff if you want to take a look too, you can flash the patch.

Comment 20

[Tiffanie Shakespeare [:tif]]

\w/ looks good!

Comment 21

[Wilson Page [:wilsonpage]]

Landed on 'master'

https://github.com/mozilla-b2g/gaia/commit/755bcf04ae562a393c55c82861c859b2acc83c66