Closed
Bug 990591
Opened 10 years ago
Closed 10 years ago
Cachebust collection images URLs with the image hash
Categories
(Marketplace Graveyard :: API, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-04-15
People
(Reporter: mat, Assigned: mat)
References
Details
(Keywords: perf)
We should apply the same idea described in bug 990295 to cachebust collection images. This would allow those images to be cached for a very long time - currently we can't do that because the cachebust string is built with the build_id, which only changes when we deploy.
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2014-04-08
Updated•10 years ago
|
Blocks: tarako-marketplace
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2014-04-08 → 2014-04-15
Updated•10 years ago
|
No longer blocks: tarako-marketplace
Assignee | ||
Comment 1•10 years ago
|
||
https://github.com/mozilla/zamboni/pull/1920
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Fixed in https://github.com/mozilla/zamboni/commit/db82f7bf76ed58d81f43c79fe1b94014eecd7748 STR: - Load a collection with some apps in consumer pages (for instance https://marketplace-dev.allizom.org/collection/dsadasdas?src=home ) - Edit that collection in curation tool, change the background image - Wait 3 minutes, refresh the consumer pages, the background should have changed -
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 3•10 years ago
|
||
I have waited for about 10 minutes and the updates were not displayed. Please see screencast http://screencast.com/t/qcCdXCsV0uf
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•10 years ago
|
||
I see the updated background, so it looks like a caching issue.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/ on FF31 (Win 7). Postfix screencast http://screencast.com/t/52WsK2QmFTo Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•