990606 - [Camera][Madai][l10n] Improve l10n for Camera Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Théo Chevalier]

Attachment: Screenshot

A couple of issues for l10n which needs to be fixed on 1.4 if Madai lands there too.

1/
The following strings are used as label and title, we should use different strings (see bug 950463):
hdr = HDR
grid = Grid
flash = Flash
self-timer = Self-timer

Please add new strings for title like, hdr-header = HDR, etc.


2/ As you can see on the attached screenshot, for labels on the left screen (the same as in the first issue), the first letter of each word is automatically uppercased ("du capteur photo" vs. "Du Capteur Photo"). It shouldn't.

Note, I used a fake translation to test things out.

Comment 1

[Théo Chevalier]

(In reply to Théo Chevalier [:tchevalier] from comment #0)
> Created attachment 8400027 [details]
> Screenshot
> 
> A couple of issues for l10n which needs to be fixed on 1.4 if Madai lands
> there too.
> 
> 1/
> The following strings are used as label and title, we should use different
> strings (see bug 950463):
> hdr = HDR
> grid = Grid
> flash = Flash
> self-timer = Self-timer

Can't test, but of course we will need new strings for
camera-resolution
video-resolution
scene-mode
as well if they are used on both settings panel and header.


However I think it is safe to reuse the label strings in the notification displayed when changing a setting.

Comment 2

[Francesco Lodolo [:flod]]

Unfortunately I can't test it either at the moment, and I missed the string reuse from the screenshot in bug 988519 :-\

Looking at your screenshot, I think the header is broken too (it should be truncated before reaching the button, not overlapping).

Comment 3

[Théo Chevalier]

Camera has been uplifted to 1.4 in https://github.com/mozilla-b2g/gaia/pull/17935, nominating this bug

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 5

[Wilson Page [:wilsonpage]]

flod: Could you re-review?

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8401783 [details]
pull-request (master)

Looks good with a couple of comments on Github.

Comment 7

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/8d7f1842b51460f3e769e8466023ba092aa092df

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/75793681d17a3db6ce9311dae3a1d0174084db9f

Comment 9

[[:RJ]]

Not enough information with current STR to write test case to address bug.

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

Test cases are in moztrap:

https://moztrap.mozilla.org/manage/case/12450/

https://moztrap.mozilla.org/manage/case/12454/

https://moztrap.mozilla.org/manage/case/12417/

https://moztrap.mozilla.org/manage/case/14346/