Bug 903149 runs the JS minifier, and potentially displays a warning message that contains the magic word "SyntaxError" like so: 17:54:07 WARNING - Warning: JS minification verification failed for ../../dist/bin/modules/KeyValueParser.jsm: 17:54:07 ERROR - Warning: 10:26 SyntaxError: missing ) after argument list: 17:54:07 WARNING - Warning: 10:26 is.init(fstream, "UTF-8" 17:54:07 WARNING - Warning: 10:26 ..........................^ Mozharness picks up on the "SyntaxError" line, and treats it as an error even though the message is prefixed with "Warning:". It would be helpful if it was treated as a warning instead. Does it make sense to only match at the start of a line? Or as aki suggested in irc: <aki> mshal: sure, we could add a /Warning .*Error:/ to PythonErrorList before the SyntaxError: to allow for that
Attachment #8400175 - Flags: review?(aki) → review+
Comment on attachment 8400175 [details] [diff] [review] mozharness-syntaxerror.patch https://hg.mozilla.org/build/mozharness/rev/2e43ed4bea7e
Attachment #8400175 - Flags: checked-in+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.