Closed Bug 990628 Opened 6 years ago Closed 6 years ago

Fix & re-enable text/wordbreak-4a.html after the landing of bug 987582


(Core :: Layout: Text and Fonts, defect)

Gonk (Firefox OS)
Not set



2.0 S1 (9may)
Tracking Status
b2g-v2.0 --- fixed


(Reporter: emorley, Assigned: jfkthame)




(2 files) (bug 987582) caused failures in text/wordbreak-4a.html:
On rev3s:
On EC2:*reft&tochange=15c185155786&fromchange=ccea983731fd

16:25 <jfkthame> edmorley|sheriffduty, i think it's likely those oranges were triggered by the font changes in a425b5eaf4949ab17a1670442fc2b17a82c84a74, though i don't totally understand why yet
16:25 <jfkthame> edmorley|sheriffduty, and i suspect the real bug is elsewhere, and just happens to be exposed by the font change
16:27 <jfkthame> edmorley|sheriffduty, would it be an option to mark them as failing on that platform and file a bug (cc'ing me and :mwu)?
16:29 <jfkthame> edmorley|sheriffduty, yeah, it's only two reftests, both involving korean chars and missing glyphs... i think there's a real code bug involved but it'll take a bit of time to investigate
Blocks: 987582
Hmm.. the use of compressed fonts is disabled by default though. I would expect the normal font set on the emulator.
(In reply to Michael Wu [:mwu] from comment #2)
> Hmm.. the use of compressed fonts is disabled by default though. I would
> expect the normal font set on the emulator.

It turns out on examining the Android build stuff that the "DroidSansFallback.ttf" package was actually giving us the font called DroidSansFallbackFull.ttf, which has more complete Korean support than DroidSansFallback.ttf.

So we should restore that.

I just opened for this, but it appears to include several previous commits that AFAIK are already merged, so it needs some kind of cleaning up. I'll see if I can make that happen, though my git knowledge is minimal...
This should fix the test failure here and in bug 990627.

We'll also need to revert the changes to the reftest manifests.
Assignee: nobody → jfkthame
Attachment #8400176 - Flags: review?(mwu)
Attachment #8400176 - Flags: review?(mwu) → review+
This will need to be pushed when the DroidSansFallback update hits our builds, otherwise the tests will go orange with UNEXPECTED-PASS.
Attachment #8400179 - Flags: review?(mwu)
Attachment #8400179 - Flags: review?(mwu) → review+
(In reply to Carsten Book [:Tomcat] from comment #7)
> landed on

Backed out since this needed to land alongside the moztt PR on b2g-inbound:

Relanded on b2g-inbound:
Blocks: 990627
The following changeset is now in Firefox Nightly:

> 35b1ed05daa1 Bug 990628 - Disable text/wordbreak-4a.html for failures after the landing of bug 987582; CLOSED TREE

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1

Download Links:

>         Linux x86:
>      Linux x86_64:
> Linux x86_64 ASAN:
>               Mac:
>             Win32:
>             Win64:

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
AFAICS, this eventually landed and merged successfully, but the bug never got resolved. Closing.
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.