Closed Bug 990685 Opened 6 years ago Closed 6 years ago

Dispatch document-element-inserted for XUL documents

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
mozilla31

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: addon-compat)

Attachments

(1 file)

Bug 579764 introduced the document-element-inserted for HTML and XML documents. It's fired immediately after the main document element is created but before any other scripts or anything have been loaded. I want to add this for XUL because it is a good way to catch new XUL documents before scripts run for the JS debugger.
Attached patch patchSplinter Review
Not sure who is a good reviewer here, please redirect if there is someone better.
Attachment #8402724 - Flags: review?(bzbarsky)
Comment on attachment 8402724 [details] [diff] [review]
patch

Looks reasonable, or as reasonable as any change to XUL code.  r=me
Attachment #8402724 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c7646be831d3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 997636
Forgot to note that this has potential add-on compat issues as found in bug 997636. I had expected add-ons to be excepting some chrome URIs already since some of the SVG used in the URI already dispatched this but apparently not.
Keywords: addon-compat
Backed out due to bug 997636: https://hg.mozilla.org/integration/fx-team/rev/6bd6ecc2185c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This isn't needed for bug 990074 after all
No longer blocks: 990074
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.