99072 - Always set 'CPU_ARCH=x86'

Status: VERIFIED FIXED

(NSS :: Build, defect, P1)

Description

[Shin'ichiro TAYA]

In 'security/coreconf/NetBSD.mk', CPU_ARCH is always set to x86.

Comment 1

[Shin'ichiro TAYA]

Attachment: suggested fix

Comment 2

[Wan-Teh Chang]

Could you tell me what 'uname -m' and 'uname -p'
on some common architectures for NetBSD?

Comment 3

[Shin'ichiro TAYA]

From uname(8)

  -p      print the machine processor architecture name.
  -m      print the machine hardware name.
e.g.
On NetBSD/i386% uname -p
i386
% uname -m
i386

On NetBSD/cobalt(little endian mips)
% uname -p
mipsel
% uname -m
cobalt

On NetBSD/mac68k
% uname -p
m68k
% uname -m
mac68k

Comment 4

[Wan-Teh Chang]

Thank you for the info on the -p and -m options of uname.

I will propose a simpler patch, based on the fact that
'uname -p' and 'uname -m' both return "i386" on NetBSD/i386.
I think we don't need to add -D$(CPU_ARCH), although I
will keep -Di386 for backward compatibility.

Comment 5

[Wan-Teh Chang]

Attachment: Proposed patch. Please review and test it.

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 56076 [details] [diff] [review]
Proposed patch.  Please review and test it.

I have no netbsd box but it looks good. r=cls

Comment 7

[Wan-Teh Chang]

Fix checked in on the tip and NSS_3_3_BRANCH of NSS.
I also moved the NSS_CLIENT_TAG.

Taya, please verify that the fix works for you.  I
think this is mostly a cosmetic change because NSS is
not really using CPU_ARCH but it is wrong to define
-Di386 for all architectures :-)

Comment 8

[Shin'ichiro TAYA]

I could build mozilla with this patch & worked fine.
veified.