Last Comment Bug 99072 - Always set 'CPU_ARCH=x86'
: Always set 'CPU_ARCH=x86'
Product: NSS
Classification: Components
Component: Build (show other bugs)
: 3.3.1
: All NetBSD
P1 normal (vote)
: 3.3.2
Assigned To: Wan-Teh Chang
: Wan-Teh Chang
Depends on:
  Show dependency treegraph
Reported: 2001-09-10 08:25 PDT by Shin'ichiro TAYA
Modified: 2001-11-03 03:46 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

suggested fix (622 bytes, patch)
2001-09-10 08:26 PDT, Shin'ichiro TAYA
no flags Details | Diff | Splinter Review
Proposed patch. Please review and test it. (584 bytes, patch)
2001-11-01 07:40 PST, Wan-Teh Chang
netscape: review+
Details | Diff | Splinter Review

Description User image Shin'ichiro TAYA 2001-09-10 08:25:32 PDT
In 'security/coreconf/', CPU_ARCH is always set to x86.
Comment 1 User image Shin'ichiro TAYA 2001-09-10 08:26:11 PDT
Created attachment 48864 [details] [diff] [review]
suggested fix
Comment 2 User image Wan-Teh Chang 2001-10-31 22:33:55 PST
Could you tell me what 'uname -m' and 'uname -p'
on some common architectures for NetBSD?
Comment 3 User image Shin'ichiro TAYA 2001-11-01 06:13:38 PST
From uname(8)

  -p      print the machine processor architecture name.
  -m      print the machine hardware name.
On NetBSD/i386% uname -p
% uname -m

On NetBSD/cobalt(little endian mips)
% uname -p
% uname -m

On NetBSD/mac68k
% uname -p
% uname -m
Comment 4 User image Wan-Teh Chang 2001-11-01 07:40:03 PST
Thank you for the info on the -p and -m options of uname.

I will propose a simpler patch, based on the fact that
'uname -p' and 'uname -m' both return "i386" on NetBSD/i386.
I think we don't need to add -D$(CPU_ARCH), although I
will keep -Di386 for backward compatibility.
Comment 5 User image Wan-Teh Chang 2001-11-01 07:40:52 PST
Created attachment 56076 [details] [diff] [review]
Proposed patch.  Please review and test it.
Comment 6 User image hacker formerly known as 2001-11-01 08:25:46 PST
Comment on attachment 56076 [details] [diff] [review]
Proposed patch.  Please review and test it.

I have no netbsd box but it looks good. r=cls
Comment 7 User image Wan-Teh Chang 2001-11-01 14:42:54 PST
Fix checked in on the tip and NSS_3_3_BRANCH of NSS.
I also moved the NSS_CLIENT_TAG.

Taya, please verify that the fix works for you.  I
think this is mostly a cosmetic change because NSS is
not really using CPU_ARCH but it is wrong to define
-Di386 for all architectures :-)
Comment 8 User image Shin'ichiro TAYA 2001-11-03 03:46:03 PST
I could build mozilla with this patch & worked fine.

Note You need to log in before you can comment on or make changes to this bug.