Always set 'CPU_ARCH=x86'

VERIFIED FIXED in 3.3.2

Status

NSS
Build
P1
normal
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Shin'ichiro TAYA, Assigned: Wan-Teh Chang)

Tracking

3.3.1
3.3.2
All
NetBSD

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

584 bytes, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
In 'security/coreconf/NetBSD.mk', CPU_ARCH is always set to x86.
(Reporter)

Comment 1

16 years ago
Created attachment 48864 [details] [diff] [review]
suggested fix
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: mozilla0.9.5, patch, review
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.3.2
Version: unspecified → 3.3.1
(Assignee)

Comment 2

16 years ago
Could you tell me what 'uname -m' and 'uname -p'
on some common architectures for NetBSD?
(Reporter)

Comment 3

16 years ago
From uname(8)

  -p      print the machine processor architecture name.
  -m      print the machine hardware name.
e.g.
On NetBSD/i386% uname -p
i386
% uname -m
i386

On NetBSD/cobalt(little endian mips)
% uname -p
mipsel
% uname -m
cobalt

On NetBSD/mac68k
% uname -p
m68k
% uname -m
mac68k
(Assignee)

Comment 4

16 years ago
Thank you for the info on the -p and -m options of uname.

I will propose a simpler patch, based on the fact that
'uname -p' and 'uname -m' both return "i386" on NetBSD/i386.
I think we don't need to add -D$(CPU_ARCH), although I
will keep -Di386 for backward compatibility.
(Assignee)

Comment 5

16 years ago
Created attachment 56076 [details] [diff] [review]
Proposed patch.  Please review and test it.
(Assignee)

Updated

16 years ago
Attachment #48864 - Attachment is obsolete: true
Comment on attachment 56076 [details] [diff] [review]
Proposed patch.  Please review and test it.

I have no netbsd box but it looks good. r=cls
Attachment #56076 - Flags: review+
(Assignee)

Comment 7

16 years ago
Fix checked in on the tip and NSS_3_3_BRANCH of NSS.
I also moved the NSS_CLIENT_TAG.

Taya, please verify that the fix works for you.  I
think this is mostly a cosmetic change because NSS is
not really using CPU_ARCH but it is wrong to define
-Di386 for all architectures :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

16 years ago
I could build mozilla with this patch & worked fine.
veified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.