990741 - Add telemetry to eyedropper

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Heather Arthur [:harth]]

We should track how often the eyedropper tool is opened with telemetry.

Comment 1

[Heather Arthur [:harth]]

I'm working on this and have it working, but I'm still thinking about how to split up the histograms.

What I want to do is measure how often people open the picker from the button, menu, and color picker. Right now I have a separate measure for each of them:

"DEVTOOLS_BUTTON_EYEDROPPER_OPENED_BOOLEAN"
"DEVTOOLS_BUTTON_EYEDROPPER_OPENED_PER_USER_FLAG"

"DEVTOOLS_PICKER_EYEDROPPER_OPENED_BOOLEAN"
"DEVTOOLS_PICKER_EYEDROPPER_OPENED_PER_USER_FLAG"

"DEVTOOLS_MENU_EYEDROPPER_OPENED_BOOLEAN"
"DEVTOOLS_MENU_EYEDROPPER_OPENED_PER_USER_FLAG"

Jeff, will this pollute the data too much? Should we have one measure for no matter how they open an eyedropper instance, or keep them separate like this and just add them up if we want to get a total measure?

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Looks good to me to keep them separate, I think we can still sum them to get an overall impression of eyedropper use, at least for a while.

Comment 3

[Heather Arthur [:harth]]

Attachment: Add telemetry to eyedropper: button, color picker button, menu item

This patch adds telemetry to the eyedropper, with separate measures for if its opened via the toolbox button, color picker button, or devtools menu. It does not track how much time it's been open as this is an open-and-close kind of tool.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8524841 [details] [diff] [review]
Add telemetry to eyedropper: button, color picker button, menu item

Review of attachment 8524841 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, r+ assuming we have a green try for this.

Comment 5

[Heather Arthur [:harth]]

Gonna wait for bug 1098374 and rebase.

Comment 6

[Heather Arthur [:harth]]

Attachment: Rebased for check in

https://tbpl.mozilla.org/?tree=Try&rev=55f0d1cacd94

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8844ff2afebc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8844ff2afebc