990793 - Build error with --disable-accessibility: nsBaseWidget.cpp:1402:14: error: member access into incomplete type 'nsIPresShell'

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Daniel Holbert [:dholbert]]

New build error in my build (with ac_add_options --disable-accessibility):
{
widget/xpwidgets/nsBaseWidget.cpp:1402:14: error: member access into incomplete type 'nsIPresShell'
     presShell->WindowSizeMoveDone();
              ^
 ../../dist/include/nsIWidgetListener.h:14:7: note: forward declaration of 'nsIPresShell'
 class nsIPresShell;
       ^
}


This presumably works in normal builds because this .cpp file has:
>47 #ifdef ACCESSIBILITY
>48 #include "nsAccessibilityService.h"
>49 #endif
http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.cpp#47
...and nsAccessibilityService.h #includes DocManager which #includes nsIPresShell.h.

In any case, nsBaseWidget.cpp should have its own #include of nsIPresShell.h.]

(Given that I'm just hitting this for the first time today, and these presShell usages have been there for a while, I'm betting this was introduced by the most recent change to this file -- mozilla-central changeset 77b2c81993b5 for bug 984271 -- which removed an #include here, which might've been indirectly getting us nsIPresShell.h before.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8aec25fc718c

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8aec25fc718c