99080 - using plugger, makes the temp file huge

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[greg jones]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3+) Gecko/20010907
BuildID:    2001090712

file takes a long time to load
the temp file looks like this after the device runs out of disk space

-rwxrwxr-x    1 gjones   gjones   812904448 Sep 10 12:12
.mozilla/gjones/mvbdo1he.slt/plugtmp/card_shuffle.wav
The original file looks like this

-r--r--r--    1 gjones   gjones     691952 Aug 16  1999 MyMusic/card_shuffle.wav

I am using the verision of plugger from the RedHat compiled from
the redhat SRPM:  plugger-3.3-4.src.rpm

The file plays only the first second or two of sound and then
goes into a loop.

File plays flawlessly in NetScape 4.78 using the same plugger.

Reproducible: Always
Steps to Reproduce:
1.just open the file after installing plugger
2.
3.

Actual Results:  device runs out of space and only the first one or two seconds
of sound plays.

Expected Results:  Play the file like NetScape 4.78

Having the same problem with the RealPlayer plugin

Comment 1

[Boris Zbarsky [:bzbarsky]]

Could you attach the wav to this bug please? 

Comment 2

[av (gone)]

May be some sort of leak. Adding serge.

Comment 3

[greg jones]

card_shuffle.wav is part of gnome-audio-extra-1.4.0 package which should be
available at ftp.gnome.org.

Comment 4

[greg jones]

Attachment: card_shuffle.wav

Comment 5

[greg jones]

This problem only seems to occur when playing a file from the local drive.
Plugger works fine from the test files from plugger's home pages.

Comment 6

[Keyser Sose]

Marking these all WORKSFORME sorry about lack of response but were very
overloaded here. Only reopen the bug if you can reproduce with the following steps:

1) Download the latest nightly (or 0.9.6 which should be out RSN)
2) Create a new profile
3) test the bug again

If it still occurs go ahead and reopen the bug. Again sorry about no response
were quite overloaded here and understaffed.

Comment 7

[Christopher Hoess (gone)]

reopening.

Comment 8

[serge (gone)]

this ia a regression from the patch (attachment id 38998) checked in to fix bug 
54689
here is why we are looping:
RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v
retrieving revision 1.325
diff -u -r1.325 nsPluginHostImpl.cpp
--- nsPluginHostImpl.cpp        2001/11/07 03:02:47     1.325
+++ nsPluginHostImpl.cpp        2001/11/14 01:09:03
@@ -2106,7 +2106,7 @@
     // if we are caching this to disk ourselves, lets write the bytes out.
     nsCOMPtr<nsIOutputStream> outStream;
     mPluginStreamInfo->GetLocalCachedFileStream(getter_AddRefs(outStream));
-    while (outStream && amountWrote <= amountRead && NS_SUCCEEDED(rv))
+    while (outStream && amountWrote < amountRead && NS_SUCCEEDED(rv))
       rv = outStream->Write(buffer, amountRead, &amountWrote);
     delete [] buffer;
   }

cc: [e-mail]

Comment 9

[Peter Lubczynski]

Ahh...much better. r=peterl  You should probably get dougt to sr= as I think
he's the orriginal author.

Comment 10

[Doug Turner (:dougt)]

d'oh!

sr=me

Comment 11

[serge (gone)]

on the trunk
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v
new revision: 1.326; previous revision: 1.325

Comment 12

[Peter Lubczynski]

nominating....

Comment 13

[Peter Lubczynski]

oops...should have mentioned that this fix is in XP code and would probably
effect other plugins...

Comment 14

[Judson Valeski]

is this linux only?

Comment 15

[serge (gone)]

this is in XP code, but we do have only linux test case

Comment 16

[Marek Z. Jeziorek]

please check the fix into 0.9.4 branch

Comment 17

[serge (gone)]

nsPluginHostImpl.cpp checked into MOZILLA_0_9_4_BRANCH
new revision: 1.288.2.8; previous revision: 1.288.2.7

Comment 18

[Judson Valeski]

adding fixed 0.9.4 keyword

Comment 19

[serge (gone)]

resolve as fixied

Comment 20

[shrirang khanzode]

this works now both on branch and trunk, linux.verified. Reporter, pls double 
check if u can, thx!

Comment 21

[greg jones]

It works fine on the build I made from the source drop of 12/10/2001.

Comment 22

[serge (gone)]

*** Bug 102123 has been marked as a duplicate of this bug. ***