990806 - Fix "Assertion failure: gGotError, at js/src/shell/js.cpp:448" after OOM in the shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

It is surprisingly hard to get this to trip using oomAfterAllocations, because that usually crashes. But for example:

$OBJDIR/dist/bin/js  -e 'const libdir = "js/src/jit-test/lib/";' -f js/src/jit-test/lib/prolog.js -e 'oomAfterAllocations(5301);' -f js/src/jit-test/tests/ion/lookupswitch.js

You may have to try several different numbers in place of 5301.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1 - Call js_ReportOutOfMemory when deliberately triggering an OOM for testing

I have no idea what the performance consequences of this will be. If the compiler is smart, none.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2 - Add an oomCallback to the shell to make the assertion correct

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8400336 [details] [diff] [review]
Part 1 - Call js_ReportOutOfMemory when deliberately triggering an OOM for testing

Review of attachment 8400336 [details] [diff] [review]:
-----------------------------------------------------------------

r=me If you get regression warnings after pushing it we can revisit.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8400337 [details] [diff] [review]
Part 2 - Add an oomCallback to the shell to make the assertion correct

Review of attachment 8400337 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=me

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/601c1ba8c437
https://hg.mozilla.org/mozilla-central/rev/05f9f8a561bc

Comment 6

[Hannes Verschore [:h4writer]]

I can still get this assertion failure rather quickly, even with this patch applied. I assume there are other places where we hit this? See bug 727333 comment 9. I don't know if you want to open a new bug for this or fix it in this bug?

Comment 7

[Jason Orendorff [:jorendorff]]

New bug, assigned to me, please.