990869 - Allow to enable sub Apzc for non WIN gecko clients

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Tatiana Meshkova (:tatiana)]

Attachment: APZC Sub Frames enabled by pref

Current gecko does sub APZC layers only for WIN
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsGfxScrollFrame.cpp#2589

It think it is would be honest allow other platforms use APZC sub frames

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 8400382 [details] [diff] [review]
APZC Sub Frames enabled by pref

Review of attachment 8400382 [details] [diff] [review]:
-----------------------------------------------------------------

Kats is the right person to review this. This should maybe use the gfxPrefs bits. We may want to check for OMTC as well.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8400382 [details] [diff] [review]
APZC Sub Frames enabled by pref

Review of attachment 8400382 [details] [diff] [review]:
-----------------------------------------------------------------

This patch as-is will disable subapzc on B2G. I agree with BenWa that you should put the pref into gfxPrefs.h. I would also rename it to apz.subframe.enabled and change the ordering to be like this:

bool wantSubAPZC = gfxPrefs::APZSubframeEnabled();
#ifdef MOZ_WIDGET_GONK
if (XRE_GetProcessType() != GeckoProcessType_Content) {
  wantSubAPZC = false;
}
#endif

and then update the prefs files so that the pref is false in all.js, and set to true in the metro (browser/metro/profile/metro.js) and b2g (b2g/app/b2g.js) prefs files. That way the prefs will be pretty representative of what's happening on the different platforms, and we have as few ifdefs as we can get away with.

Comment 3

[Tatiana Meshkova (:tatiana)]

Attachment: Allow enable APZC Sub Frames by pref

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8400707 [details] [diff] [review]
Allow enable APZC Sub Frames by pref

Review of attachment 8400707 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed

::: gfx/thebes/gfxPrefs.h
@@ +125,5 @@
>    DECL_GFX_PREF(Live, "apz.x_skate_size_multiplier",           APZXSkateSizeMultiplier, float, 1.5f);
>    DECL_GFX_PREF(Live, "apz.x_stationary_size_multiplier",      APZXStationarySizeMultiplier, float, 3.0f);
>    DECL_GFX_PREF(Live, "apz.y_skate_size_multiplier",           APZYSkateSizeMultiplier, float, 2.5f);
>    DECL_GFX_PREF(Live, "apz.y_stationary_size_multiplier",      APZYStationarySizeMultiplier, float, 3.5f);
> +  DECL_GFX_PREF(Live, "apz.subframe.enabled",                  APZSubframeEnabled, bool, false);

Please move this up to be in alphabetical order (so just after pan_repaint_interval)

::: modules/libpref/src/init/all.js
@@ +331,5 @@
>  
>  // Whether to print the APZC tree for debugging
>  pref("apz.printtree", false);
>  
> +// Whether to allow build sub layers tree for iframes

Change this comment to "Layerize scrollable subframes to allow async panning". You can just leave the comment in this file and remove it from the other two prefs files.

Comment 5

[Tatiana Meshkova (:tatiana)]

Attachment: Allow enable APZC Sub Frames by pref

Transfer r+

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b27234ae13e8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b27234ae13e8