Closed Bug 991034 Opened 6 years ago Closed 6 years ago

Remove unused strings from browser.dtd

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
"the following strings are unused in Australis, they're kept here to avoid warnings from l10n tools like compare-locales on l10n-central. They will be definitely removed when Australis is ready for mozilla-aurora."

Australis is on mozilla-beta now.
Attachment #8400575 - Flags: review?(dolske)
Comment on attachment 8400575 [details] [diff] [review]
patch

Review of attachment 8400575 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8400575 - Flags: review?(dolske) → review+
Backed out for startup crashes; guessing the strings were still being used:
https://tbpl.mozilla.org/?tree=Fx-Team&rev=10a99a32304b

remote:   https://hg.mozilla.org/integration/fx-team/rev/ddc22f087bec

I'll file a bug so we detect the missing strings sooner (and in a more clear manner).
(In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> I'll file a bug so we detect the missing strings sooner (and in a more clear
> manner).

Bug 992316
Indeed at least switchToMetroCmd2.label, bookmarksMenuButton.tooltip and appMenuSidebars.label are still used.
(In reply to Marco Bonardo [:mak] from comment #5)
> Indeed at least switchToMetroCmd2.label, bookmarksMenuButton.tooltip and
> appMenuSidebars.label are still used.

Probably "again" rather than "still"...
Depends on: 993084
No longer depends on: 993084
https://hg.mozilla.org/mozilla-central/rev/1eab0ad18dff
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.