991039 - hang after "move to new window" for about:sessionrestore

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Attachment: windbg stack FF hung Wednesday 2014-04-02.txt

windows vista 31.0a1 (2014-04-01)

breakpad on stack - for flash plugin?

anyway, had a window with 20-30 tabs including about:sessionrestore.
thought I'd try moving about:sessionrestore tab to a new window.
new window appeared, no about:sessionrestore information
waited
hung

only ~1GB working set for firefox at the time

Comment 1

[(not currently active) Ted Mielczarek]

So you're deadlocked because the IOInterposer code got called by way of CreateFile from the minidump callback, but it tried to malloc and got stuck. bug 973353 was supposed to fix this, but it looks like we didn't fix it properly (oops). Specifically, on Windows we're using the FPEFilter function:
http://hg.mozilla.org/mozilla-central/annotate/7bacc9e903b0/toolkit/crashreporter/nsExceptionHandler.cpp#l1130
http://hg.mozilla.org/mozilla-central/annotate/7bacc9e903b0/toolkit/crashreporter/nsExceptionHandler.cpp#l871

and not the Filter function, so the disabling isn't happening.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8400762 [details] [diff] [review]
Fix

Review of attachment 8400762 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I missed this in my original review!

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d07b3f034bd5

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d07b3f034bd5

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8400762 [details] [diff] [review]
Fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 902587
User impact if declined: Windows users might not be able to generate crash reports under certain conditions.
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5cc3fa9d6e68

Comment 8

[629555a]

Attachment: AcroRd32.exe

Comment 9

[Jason Smith [:jsmith]]

Please don't flip flags on things you don't understand.

Comment 10

[Andrei Vaida [:avaida]]

I was unable to reproduce this issue on Nightly 31.0a1 (2014-04-01) nor on Firefox 31 Beta 9 (Build ID: 20140710141843) using Windows Vista 32-bit. Several attempts were made using 30 to 50 tabs, but moving the about:sessionrestore tab to a new window via "Move to New Window" right-click action or by drag&drop didn't cause any issues.

Wayne, could you please try to reproduce this bug using Firefox 31 Beta 9 [1] and confirm whether it's fixed or not on your end?

[1] http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/31.0b9-candidates/build1/

Comment 11

[Wayne Mery (:wsmwk)]

Thanks for the patch and everyone's help
WFM smooth as silk with 20140705 build