Closed Bug 991075 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_keybindings.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: Yoric, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Once bug 991040 lands, the following error will cause will cause oranges:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_keybindings.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:872 - TypeError: this.doc is undefined
 1:14.26 Stack trace:
 1:14.26     Toolbox.prototype.focusTool@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:872:1
 1:14.26 Toolbox.prototype.selectTool/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:858:7
 1:14.26 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:821:11
 1:14.26 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:700:7

I suggest applying the patch of bug 991040 to reproduce.
I have no clear understanding of what is going on.
Paul, could you assign this to someone?
Flags: needinfo?(paul)
Blocks: 1018184
Assignee: nobody → jsantell
Attached patch 991075-framework-promises.patch (obsolete) — Splinter Review
Attachment #8439594 - Flags: review?(jryans)
Flags: needinfo?(paul)
Comment on attachment 8439594 [details] [diff] [review]
991075-framework-promises.patch

Review of attachment 8439594 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/test/browser_keybindings.js
@@ +73,5 @@
>        keysetMap.inspector.synthesizeKey();
>  
>        aToolbox.once("picker-stopped", () => {
>          ok(true, "picker-stopped event received, highlighter stopped");
> +        gDevTools.once("select-tool-command", () => {

Do you need |gDevTools.once| here *and* inside |webconsoleShouldBeSelected|?  Seems like one or other would suffice...  This applies to the debugger and netmonitor cases too.
Attachment #8439594 - Flags: review?(jryans) → review+
It's for the cascading tools -- inspectorShouldBeOpenAndHighlighting has the |gDevTools.once| for the selection of webconsole, and webconsoleShouldBe... has |gDevTools.once| for the debugger, etc.
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> It's for the cascading tools -- inspectorShouldBeOpenAndHighlighting has the
> |gDevTools.once| for the selection of webconsole, and webconsoleShouldBe...
> has |gDevTools.once| for the debugger, etc.

Ah okay, makes sense.
Attachment #8439594 - Attachment is obsolete: true
Attachment #8439621 - Flags: review+
Status: NEW → ASSIGNED
Do you have a Try link for this by chance? :)
Keywords: checkin-needed
Looking good!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f009ccbea0e6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: