Closed Bug 991220 Opened 10 years ago Closed 10 years ago

Remove Ubuntu One Support From Thunderbird

Categories

(Thunderbird :: FileLink, defect)

defect
Not set
normal

Tracking

(thunderbird31+ fixed)

RESOLVED FIXED
Thunderbird 31.0
Tracking Status
thunderbird31 + fixed

People

(Reporter: bkerensa, Assigned: sshagarwal)

Details

Attachments

(1 file, 1 obsolete file)

Since Canonical Ltd. has announced[1] it is shuttering the Ubuntu One service we should proceed with plans to end support for Ubuntu One in Thunderbird.

[1]http://www.thebolditalic.com/articles/4717-hacked-prius-running-on-muni-power-lines
Mike, I would also be willing to take this once we decide which release will will remove it at.
(In reply to Benjamin Kerensa [:bkerensa] from comment #1)
> Mike, I would also be willing to take this once we decide which release will
> will remove it at.

Sounds good - would happily review that patch.
We'll have to do it for tb 31 (which will even be somewhat late). 

"The current services will be unavailable from 1 June 2014; user content will remain available for download until 31 July, at which time it will be deleted."
Hello,

My name is Dimitri Ledkov, and I work for Canonical in Ubuntu Engineering and I am coordinating removal/disabling of features that depend on U1 file syncing. We have considered notifying mozilla security team ahead of public announcement, but didn't so due to various timing issues. We have preliminary patches to remove this feature, which are currently being tested. Chris Coulson from Ubuntu Security team and I are working on it. So please don't spend duplicate time on this, but rather review our patch. We'll submit it here shortly. I have managed to push patches for all other projects today, so thunderbird is the last one to complete. Ideally we'd like it to be part of security releases for all/any series that are still getting security/bugfix releases, since once the U1 service is shutdown all users will be affected. In Ubuntu, it will be included as part of security updates for all supported releases, I don't have any information what other distributions might do that ship U1 integration in thunderbird.

Regards,

Dimitri.
(In reply to Dimitri Ledkov from comment #4)
> Hello,
> 
> My name is Dimitri Ledkov, and I work for Canonical in Ubuntu Engineering
> and I am coordinating removal/disabling of features that depend on U1 file
> syncing. We have considered notifying mozilla security team ahead of public
> announcement, but didn't so due to various timing issues. We have
> preliminary patches to remove this feature, which are currently being
> tested. Chris Coulson from Ubuntu Security team and I are working on it. So
> please don't spend duplicate time on this, but rather review our patch.
> We'll submit it here shortly. I have managed to push patches for all other
> projects today, so thunderbird is the last one to complete. Ideally we'd
> like it to be part of security releases for all/any series that are still
> getting security/bugfix releases, since once the U1 service is shutdown all
> users will be affected. In Ubuntu, it will be included as part of security
> updates for all supported releases, I don't have any information what other
> distributions might do that ship U1 integration in thunderbird.
> 
> Regards,
> 
> Dimitri.

Hi Dimitri,

This will work for us we would be happy to review your patch.
I'd like to note that the alpha for tb 31 (the next ESR) is in about two weeks. As this would include string (l10n) changes we should get the removal patch landed by then. 
If we need this for security updates, for that we need a patch that doesn't actually remove any l10n strings.
Assignee: nobody → info
Dimitri: any update on the patch?
(In reply to Magnus Melin from comment #7)
> Dimitri: any update on the patch?

Dimitri: Ideally we need this today or tomorrow so that we can integrate it into our branches.

If we need to disable it in TB 24 as comment 3 might suggest for the last couple of security releases, that would be useful to know as well.
Flags: needinfo?(info)
Attached patch Patch v1 (obsolete) — Splinter Review
I tried to do it so thought to attach the patch in case Ubuntu folks are busy.

Thanks.
Attachment #8410809 - Flags: feedback?(archaeopteryx)
Comment on attachment 8410809 [details] [diff] [review]
Patch v1

Review of attachment 8410809 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/linux/jar.mn
@@ -265,5 @@
>    skin/classic/messenger/newmailaccount/success-border.png    (mail/newmailaccount/success-border.png)
>    skin/classic/messenger/newmailaccount/success-compose.png   (mail/newmailaccount/success-compose.png)
>    skin/classic/messenger/newmailaccount/success-signature.png (mail/newmailaccount/success-signature.png)
>    skin/classic/messenger/newmailaccount/search.png            (mail/newmailaccount/search.png)
> -  skin/classic/messenger/icons/ubuntuone.png                  (mail/icons/ubuntuone.png)

Also remove the icons from mail\themes\*\mail\icons (Windows also has Aero)
Attachment #8410809 - Flags: feedback?(archaeopteryx) → feedback+
Attached patch Patch v1.2Splinter Review
Thanks for the quick feedback.

(In reply to Archaeopteryx [:aryx] from comment #10)

> Review of attachment 8410809 [details] [diff] [review]:
> ::: mail/themes/linux/jar.mn
> @@ -265,5 @@
> > -  skin/classic/messenger/icons/ubuntuone.png                  (mail/icons/ubuntuone.png)
> 
> Also remove the icons from mail\themes\*\mail\icons (Windows also has Aero)
I couldn't find the aero icon for ubuntuone.
Attachment #8410809 - Attachment is obsolete: true
Attachment #8410835 - Flags: review?(mkmelin+mozilla)
It is a pity the storage provides need so much code to support them. And now it all goes away.

Suyash, thanks for picking this up!
Sorry for the delay. Indeed my stub patch is almost identical to Suyash's one, sans context differences (mine was on top of thunderbird 24 which still uses YouSendIt instead of HighTail name).

As far as I can tell there is no aero specific ubuntuone icon, the same icon as for classic interface is used and in Suyash's patch it is removed.

I've test build Suyash's patch and it works correctly and ubuntuone is no longer offered as an option to use/setup.

Comparing the patch against tarball (instead of hg tip) there are a bunch of l10n directories for UbuntuOne, but i presume those would be gone in the release tarball since there are no references left to the translated files.

Please merge patch from https://bugzilla.mozilla.org/show_bug.cgi?id=991220#c11
Flags: needinfo?(info)
Yeah, we always need the patch against current trunk.
@:aceman patch from https://bugzilla.mozilla.org/show_bug.cgi?id=991220#c11 applies cleanly against hg-tip for me with $ hg import. Is something missing?
(In reply to Dimitri Ledkov from comment #15)
> @:aceman patch from https://bugzilla.mozilla.org/show_bug.cgi?id=991220#c11
> applies cleanly against hg-tip for me with $ hg import. Is something missing?

No, I just commented on your starting a patch against TB 24.
Comment on attachment 8410835 [details] [diff] [review]
Patch v1.2

By inspection, this all looks like the right removals.

We'll want to make sure this gets added to the release notes.

Assuming a green try run, and that you tested this on a profile that once had an UbuntuOne account set up, r=me.
Attachment #8410835 - Flags: review+
Oh, I wasn't receiving any emails regarding activity on this bug. I wasn't cc'ed :P
Sent to try - https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=df67ddf3efb5

Dimitri: for the 24 security updates your patch could be useful. It should not remove any dtd entries however.
Assignee: info → syshagarwal
Status: NEW → ASSIGNED
OS: Linux → All
Attachment #8410835 - Flags: review?(mkmelin+mozilla) → review+
Are we ready to roll this in?
Keywords: checkin-needed
Try build is still baking.
Keywords: checkin-needed
(In reply to Suyash Agarwal (:sshagarwal) away till 7th of May from comment #11)
> > Also remove the icons from mail\themes\*\mail\icons (Windows also has Aero)
> I couldn't find the aero icon for ubuntuone.

Sorry, it is the same file like the normal Windows theme.
Not the best of try runs, but looks like it's all known issues and infra problems.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/723fdaa34a16
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.