991290 - Remove option to upload add-on for Maemo platform

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[:Margaret Leibovic]

Attachment: Screen Shot 2014-04-02 at 1.55.27 PM.PNG

We stopped shipping Firefox for Maemo years ago, we should probably remove this option.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

This means removing the Maemo option and All Mobile Platforms option from all upload forms (leaving only Android), and making sure the platform support detection doesn't break. Marking it as a P2 because it can be confusing for developers.

Comment 2

[Kris Maglione [:kmag]]

I strongly suspect that the presence of a Maemo option is much more confusing than removing it would be, given that we don't actually support Maemo, and haven't in a long time.

In any case, this is going to require removing those constants, and running a migration to drop any Maemo appsupport entries. 'All Mobile' should be translated to separate Android and Maemo entries at time of submission, so that shouldn't be an issue.

Comment 3

[David Larlet [:davidbgk]]

I submitted https://github.com/mozilla/olympia/pull/395 but I wonder if we could remove files from the database with that platform id given that there are 95 files with it and even recent ones (about one per month this last year). Thoughts?

Comment 4

[Kris Maglione [:kmag]]

I don't have any problem with removing the files. Just about all of the recent files I've seen claiming compatibility with Maemo are just from people ticking all of the platform boxes, and are not actually valid.

If we can keep the files without continuing to offer the option, I think that would be preferable, but if it's difficult, I wouldn't worry about it.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

For context Mameo/Meego were dropped as supported platforms on June 26, 2012, with the release of Fx14. There was some community support from :romaxa for a few releases but that wrapped up by Firefox 17, November 19, 2012. The Maemo port has been dead for over 2 years.

Comment 6

[David Larlet [:davidbgk]]

Thanks for your answers, I think that we have two options:

* keeping those files (doesn't cause any issue) and declaring a low priority bug to delete those in a few months
* taking a look at the latest files to be sure that it's a check-all error and remove all files for that platform

I'm more in favor of the second option to let the project in a clean state.

BTW, I think it's a bit confusing now to have only two options: all mobile platforms and android, I think it deserves a line of explanation for the developer on top of those options.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to David Larlet [:davidbgk] from comment #6)
> BTW, I think it's a bit confusing now to have only two options: all mobile
> platforms and android, I think it deserves a line of explanation for the
> developer on top of those options.

There shouldn't be a need for the All Mobile Platforms option now that there's only going to be one.

Comment 8

[David Larlet [:davidbgk]]

I removed completely the All Mobile Platforms option but now there is only one choice which looks a bit weird.

About the migration, I didn't get a clear answer so I let the files as-is for now and let Mathieu taking care of this if that's eventually required.

To QA: given that I removed both a "fake" option (all) and a "real" one (maemo), it might be interesting to test different cases (old add-ons with maemo option checked, new with android only, and so on).

Comment 9

[Kris Maglione [:kmag]]

Agreed, All Mobile Platforms is currently just a shorthand for selecting Android and Maemo. There's no reason for it to stay when there aren't multiple choices.

Do you think having only one choice looks weird even when there are also desktop options offered? Maybe in the case when it's the actual only option, the checkbox input widget should be replaced by a checkmark character (✔)?

Comment 10

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/9d16133697b8689929bdce371b219d6b0caae266

I've created bug 1119800 to deal with the remaining maemo addons.

If you believe we should do something about this "only one choice which looks a bit weird" issue, please open a new bug for it.

Comment 11

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to :Margaret Leibovic from comment #0)
> Created attachment 8400870 [details]
> Screen Shot 2014-04-02 at 1.55.27 PM.PNG
> 
> We stopped shipping Firefox for Maemo years ago, we should probably remove
> this option.

Verified as fixed on AMO-dev FF36(Win 7)
Postfix screenshot http://screencast.com/t/vbr0ceoMy

If there are another things we should check please add some STR.
Thanks!