Closed Bug 991291 Opened 10 years ago Closed 10 years ago

re-organize css so it's sane

Categories

(Input Graveyard :: Code Quality, defect)

Product:
Input Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: u=dev c=codequality p=1 s=input.2014q2) 

All the dashboard css/js is intertwined with the base css/js in the base app. That's ... gross. It's in the wrong place, hard to find sometimes and having everything lumped into the same files means we have unused css for some pages.

The dashboard css/js should get extracted from the base app and moved to the analytics app.
My bad--it's just the css files that are all intertwined.

There are dribs and drabs in fjord/base/static/css/dashboard.less and that file is also used by the analyzer-specific-stuff templates. That should all get split out and reorganized into something more sane and modular.

Adding the mentor flag to this.  If you're interested in working on this, let me know in the bug comments or on IRC in the #input channel on irc.mozilla.org.
Summary: move dashboard css/js to analytics/ app → move dashboard css to analytics/ app
Whiteboard: u=dev c=codequality p= s=input.2014q2 [mentor=willkg]
Generalizing this to cover the whole site. Mostly it involves moving css around so it's better organized. E.g. the dashboard css should be in the analytics app.

Also, de-mentoring it.

Also, taking it and doing it now. Why now? Because there's a bunch of css in unpredictable places and if it was in predictable places, it makes it easier to do a style overhaul.

I think this is 1 point of work. The site is pretty small, so it's not hard to do.
Assignee: nobody → willkg
Summary: move dashboard css to analytics/ app → re-organize css so it's sane
Whiteboard: u=dev c=codequality p= s=input.2014q2 [mentor=willkg] → u=dev c=codequality p=1 s=input.2014q2
Landed in master: https://github.com/mozilla/fjord/commit/2555f55

Having done that, there's some goofy stuff in mobile/ directories. We no longer do mobile/ stuff, so I'm going to take some time to move that around now, too.
Did another cleanup pass in this PR: https://github.com/mozilla/fjord/pull/292

That fixes a lot of goofy issues that make it hard to think about the site as distinct parts.
Pushed to production just now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.