Closed Bug 991343 Opened 6 years ago Closed 4 years ago

Default to --log-no-times when running under emacs

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

I use M-x compile in emacs to compile the tree, but the timestamps prevent warnings and errors from being automatically detected in the compilation output. I suppose what I really want is for --log-no-times to be set for just the build command, but it's a global command and so it seems like it would be a little messy to restrict it.
This patch just universally defaults logging off when running inside emacs.
Attachment #8400927 - Flags: review?(gps)
Comment on attachment 8400927 [details] [diff] [review]
Default to --log-no-times when running under emacs

Review of attachment 8400927 [details] [diff] [review]:
-----------------------------------------------------------------

You might want to throw a comment in here. Otherwise, things look fine.
Attachment #8400927 - Flags: review?(gps) → review+
Why not just add the stuff you want to compilation-error-regexp-alist?

(require 'compile)

;; JavaScript stack frame formatted by testing/xpcshell/head.js's
;; _format_exception_stack, possibly with mach timestamp at the front.
(add-to-list 'compilation-error-regexp-alist
             '("^\\(?: *[0-9]+:[0-9][0-9]\\.[0-9][0-9] \\)JS frame :: \\([^ \n]*\\) :: .* :: line \\([0-9]+\\)$" 1 2))
(add-to-list 'compilation-error-regexp-alist
             '("^[^@\n]*@\\(/[^: \n]*\\):\\([0-9]+\\)$" 1 2))
(add-to-list 'compilation-error-regexp-alist
             '("^ *[0-9]+:[0-9][0-9]\\.[0-9][0-9] \\([^: \n]*\\):\\([0-9]+\\):" 1 2))

;; xpcshell test failure report.
(add-to-list 'compilation-error-regexp-alist
             '("^\\(?: *[0-9]+:[0-9][0-9]\\.[0-9][0-9] \\)TEST-UNEXPECTED-FAIL | \\([^|]+\\) |" 1))
https://hg.mozilla.org/mozilla-central/rev/c3470e440222
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.