991392 - Make the separator between the watch expressions and variables view visible in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

In bug 917226, I "fixed" what I thought was a typo in debugger.xul:

> <splitter class="devtools-horizontal-splitter devtools-invisible splitter"/>

Notice the space between "invisible" and "splitter". The actual class name is "devtools-invisible-splitter", so I changed it to:

> <splitter class="devtools-horizontal-splitter devtools-invisible-splitter"/>

However, upon investigation, we actually want it to be visible, so the previous typo was, in fact, allowing the expected visibility on that splitter :)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8400985 [details] [diff] [review]
v1

Review of attachment 8400985 [details] [diff] [review]:
-----------------------------------------------------------------

Heh.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d53cc3ad38ec

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out (along with the other patches in that push) in https://hg.mozilla.org/integration/fx-team/rev/a192ea8b6fce for causing browser-chrome-1 tests to start leaking by adding tests, which pushed other tests into a different chunk, making them leak.

Comment 5

[Victor Porof [:vporof][:vp]]

The patch in this bug doesn't have tests, so the reasoning that it can cause bc-1 tests to start leading by "adding tests" is false.

Relanded: https://hg.mozilla.org/integration/fx-team/rev/a6745130dded

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Victor Porof [:vporof][:vp] from comment #5)
s/leading/leaking, of course.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6745130dded