99140 - Memory leak of 268 bytes from 1 block allocated in nsWindowConstructor

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

MLK: Memory leak of 268 bytes from 1 block allocated in nsWindowConstructor
        Distribution of leaked blocks
               268 bytes from 1 block of 268 bytes (0x0ee466f8) 
        Allocation location
            new(UINT)+0xc        [new.cpp:23 ip=0x002da05c]
            nsWindowConstructor+0x69
[c:\moz_src\mozilla\widget\src\build\nsWinWidgetFactory.cpp:56 ip=0x05711539]
            nsGenericFactory::CreateInstance(nsISupports *,nsID const&,void *
*)+0x79 [c:\moz_src\mozilla\xpcom\components\nsGenericFactory.cpp:59 ip=0x101107e9]
            nsComponentManagerImpl::CreateInstance(nsID const&,nsISupports
*,nsID const&,void * *)+0x13c
[c:\moz_src\mozilla\xpcom\components\nsComponentManager.cpp:1544 ip=0x1011ce2c]
            nsComponentManager::CreateInstance(nsID const&,nsISupports *,nsID
const&,void * *)+0xd3
[c:\moz_src\mozilla\xpcom\components\nsComponentManager.cpp:3072 ip=0x10125b53]
            nsCreateInstanceByCID::()(nsID const&,void * *)const+0x8a
[c:\moz_src\mozilla\xpcom\components\nsComponentManager.cpp:149 ip=0x10113aae]
            nsCOMPtr<nsIWidget>::assign_from_helper(nsCOMPtr_helper const&,nsID
const&)+0x62 [.\..\..\..\dist\include\nsCOMPtr.h:971 ip=0x047715c7]
            nsCOMPtr<nsIWidget>::=(nsCOMPtr_helper const&)+0x65
[.\..\..\..\dist\include\nsCOMPtr.h:602 ip=0x0478fd95]
            nsWebShellWindow::Initialize(nsIXULWindow *,nsIAppShell *,nsIURI
*,int,int,UINT,int,int,int,nsWidgetInitData&)+0x155
[c:\moz_src\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp:255 ip=0x04787e05]
            nsAppShellService::JustCreateTopWindow(nsIXULWindow *,nsIURI
*,int,int,UINT,int,int,int,nsIXULWindow * *)+0x459
[c:\moz_src\mozilla\xpfe\appshell\src\nsAppShellService.cpp:693 ip=0x047792b9]

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

This leak is still here, I'll attach a full, updated stack.

Steps to Reproduce:

1.  Launch mozilla.exe -mail (have NO password saved on your IMAP account).
2.  This will bring up the password dialog, leave it null and hit OK.
3.  The window will bounce back, hit the OK dialog on 'incorrect password 
entered'.
4.  Now, hit cancel and exit Mozilla.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Full leak stack

Comment 3

[Dan M]

I'm not quite sure how to read this bug. But I think it's referring to the fact
that top-level window widgets are leaked. In particular I've noticed that the
outermost nsWindow of a prompt window is never released. Steps to reproduce:
  breakpoints in nsWindow constructor and destructor
  type javascript:void(alert('hi')) in the URL bar
  hit OK in the alert
notice that two nsWindows are built, but only one is destroyed. This should
probably be my bug, Paul. Dump it on me if you don't want it.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Paul isn't going to get to this... ;-(

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

re-assigning to dan

Comment 6

[Peter Trudelle]

ADT would like to know if comment#1 is the only way to reproduce the leak, and
if any other memory is being referenced from the leaked block.  cc cathleen.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

ADT: http://bugzilla.mozilla.org/show_bug.cgi?id=99140#c3

Comment 8

[Ere Maijala (slow)]

I've created a patch to 116074 (it has not been reviewed yet though). Maybe this
is the same leak that my patch is supposed to fix.

Comment 9

[Dan M]

Ere's fix for bug 116074 plugs this leak.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with the latest trunk and Purify.

Thanks!