gfxFontNameList is unused and should be removed

RESOLVED FIXED in mozilla31

Status

()

Core
Graphics: Text
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla31
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The class "gfxFontNameList" has no usages in the tree. It dates to pre-hg days (at which point it was used); all usages have now been removed.

I believe the last usages were removed in mozilla-central changeset d062597e5b3d for bug 449356.
(Assignee)

Comment 1

3 years ago
Created attachment 8401010 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8401010 - Flags: review?(jfkthame)
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
(Assignee)

Comment 2

3 years ago
MXR search, showing that it's unused (outside of its class declaration & single function definition):
 http://mxr.mozilla.org/mozilla-central/search?string=gfxFontNameList

Comment 3

3 years ago
Comment on attachment 8401010 [details] [diff] [review]
fix

Looks good.
Attachment #8401010 - Flags: review+
(Assignee)

Comment 4

3 years ago
Thanks! I'll land (with r=jdaggett) when the tree reopens.
(Assignee)

Comment 5

3 years ago
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/c064b7930598
Comment on attachment 8401010 [details] [diff] [review]
fix

Review of attachment 8401010 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this needs my review as well, but r+ anyhow!
Attachment #8401010 - Flags: review?(jfkthame) → review+
(Assignee)

Comment 7

3 years ago
Oops, I thought that review request had been canceled. :) Thanks anyhow!
https://hg.mozilla.org/mozilla-central/rev/c064b7930598
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.