Closed
Bug 991600
Opened 10 years ago
Closed 10 years ago
Intermittent test_beaconContentPolicy.html | Test timed out.
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
Tracking | Status | |
---|---|---|
firefox29 | --- | unaffected |
firefox30 | --- | unaffected |
firefox31 | --- | fixed |
firefox-esr24 | --- | unaffected |
People
(Reporter: cbook, Assigned: ehsan.akhgari)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.76 KB,
patch
|
rbarnes
:
review+
|
Details | Diff | Splinter Review |
Android 2.3 Emulator mozilla-central opt test mochitest-8 on 2014-04-02 20:35:39 PDT for push 9b06a805147b slave: tst-linux64-spot-093 https://tbpl.mozilla.org/php/getParsedLog.php?id=37185155&tree=Mozilla-Central 921 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/beacon/test_beaconContentPolicy.html | Test timed out.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Actually cc'ing the person who wrote and checked in this test might help give this more traction :-)
Oops, my bad, that had already been done.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 14•10 years ago
|
||
Landed a debugging patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f9e83390b46
Keywords: leave-open
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 19•10 years ago
|
||
This is a race condition in the test. When addCategoryEntry is called, we schedule a runnable from nsCategoryManager::NotifyObservers which is what ultimately updates the nsCategoryCache member of nsContentPolicy with the content policy added inside the test. That runnable races with the asynchronous call to beginTest, and if it wins the race, the test passes, but if it loses the test, we end up running sendBeacon before nsContentPolicy is aware of the newly added policy. I have a simple fix. I also reverted the debugging patch here: https://hg.mozilla.org/integration/mozilla-inbound/rev/56fe9fa6abcd
Assignee | ||
Comment 20•10 years ago
|
||
Assignee: nobody → ehsan
Attachment #8409388 -
Flags: review?(rlb)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 25•10 years ago
|
||
Comment on attachment 8409388 [details] [diff] [review] Patch (v1) Review of attachment 8409388 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me, with my minimal knowledge of SpecialPowers.
Attachment #8409388 -
Flags: review?(rlb) → review+
Assignee | ||
Comment 26•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/39041565bfa9
Assignee | ||
Updated•10 years ago
|
Updated•10 years ago
|
Target Milestone: --- → mozilla31
Updated•10 years ago
|
status-firefox29:
--- → unaffected
status-firefox30:
--- → unaffected
status-firefox31:
--- → fixed
status-firefox-esr24:
--- → unaffected
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•