991641 - [v1.3] Backport test_clock_set_alarm.py to v1.3

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Bob Silverberg [:bsilverberg]]

This test needs to be brought into v1.3 from master. It will replace test_clock_set_alarm_repeat.py, test_clock_set_alarm_sound.py, test_clock_set_alarm_snooze.py & test_clock_set_alarm_time.py. Marking as P2 as it is not a smoke test.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/18034

Comment 2

[Bob Silverberg [:bsilverberg]]

These changes should also allow for the deletion of test_clock_turn_on_off_alarm.py. Sorry, I missed that one the first time.

I think the best thing to do would be to update all of the clock tests to match what's currently in master, as it seems like some of them have some improvements.

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8402652 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18034

See my comment in the PR and also the new comment in this bug.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8402652 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18034

see the travis error:


Traceback (most recent call last):

File "tests/python/gaia-ui-tests/gaiatest/cli.py", line 4, in <module>

main()

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/runtests.py", line 49, in main

cli(runner_class=GaiaTestRunner, parser_class=GaiaTestOptions)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/runtests.py", line 28, in cli

runner = startTestRunner(runner_class, options, tests)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/runtests.py", line 19, in startTestRunner

runner.run_tests(tests)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/runner/base.py", line 718, in run_tests

self.run_test(test)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/runner/base.py", line 819, in run_test

self.run_test(i["path"], i["expected"])

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/runner/base.py", line 836, in run_test

**self.test_kwargs)

File "/usr/local/lib/python2.7/dist-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 297, in add_tests_to_suite

test_mod = imp.load_source(mod_name, filepath)

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_create_new_alarm.py", line 6, in <module>

from gaiatest.apps.clock.app import Clock

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/clock/app.py", line 7, in <module>

from marionette.wait import Wait

ImportError: No module named wait

Comment 5

[Bob Silverberg [:bsilverberg]]

We're not going to bring this into v1.3 after all. Marking as wontfix.