991686 - [GTK3] download "Open containing folder" button does not open Files

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Horak [:jhorak]]

Description of problem:


Version-Release number of selected component (if applicable): 29a1 (Jan-17)


How reproducible: Always


Steps to Reproduce:
1. Download a file
2. From the door hanger or downloads window select the "open containing folder" icon

Actual results: Dialog appears asking for the user to set the default application for file links
 

Expected results: Nautilus/Files opens and the downloaded file is selected

Additional info: If a user sets /usr/bin/nautilus as the default app for file links Nautilus/Files is launched but the file is not selected.

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1056322

Comment 1

[Jan Horak [:jhorak]]

Attachment: gtk3-build-with-gio.patch

Attaching simple fix, we've missed some configure.in change.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8401298 [details] [diff] [review]
gtk3-build-with-gio.patch

"$MOZ_ENABLE_GTK" looks like the usual thing to test, but please ask a build peer, such as :glandium to review.

Comment 3

[Jan Horak [:jhorak]]

Attachment: gtk3-build-with-gio.patch v2

Thanks for the review, asking Mike this time.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9f369349de8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e9f369349de8

Comment 6

[Catalin Varga [QA][:VarCat]]

Based on the feedback provided by Mike in bug 982964:

"Gtk+3 is a work in progress currently, and there were many problems in 31 with
its. It may not even build. The first version that kind of works in 32, but
really, I think it's not worth worrying more than 33 at this point.
"
I'm removing the "verifyme" keyword.